Lint everything

[victorlin]

Description of proposed changes

Apply linting rules more uniformly and (TODO) address violations.

Related issue(s)

Prompted by #1073 (comment). I added eqeqeq: error to .eslintrc.yaml, realized it didn't apply to static-site, and went down the rabbit hole.

Checklist

• Address newly surfaced violations
  • prefer-const
  • no-use-before-define
  • operator-linebreak
  • quote-props
• Checks pass
• Check if changes affect the resource index JSON revision

blocked Dependent on external development on Convert static-site from Pages Router to App Router

[victorlin]

Task: address prefer-const violations

There is 1. I will fix it.

static-site/src/components/ListResources/dodge.js
  50:13  error  'y' is never reassigned. Use 'const' instead  prefer-const

[victorlin]

Task: address no-use-before-define violations

There are 110. Example:

static-site/src/templates/displayMarkdown.jsx
  52:10  error  'MobileToggleIconContainer' was used before it was defined  no-use-before-define
  53:12  error  'MobileToggleIcon' was used before it was defined           no-use-before-define
  57:10  error  'GreyOverlay' was used before it was defined                no-use-before-define
  72:10  error  'SidebarBodyFlexContainer' was used before it was defined   no-use-before-define
  73:12  error  'SidebarContainer' was used before it was defined           no-use-before-define
  82:12  error  'ContentContainer' was used before it was defined           no-use-before-define
  84:16  error  'PostDate' was used before it was defined                   no-use-before-define
  85:16  error  'PostTitle' was used before it was defined                  no-use-before-define
  86:16  error  'PostAuthor' was used before it was defined                 no-use-before-define

This was added per nextstrain/auspice#1665 (comment). It's categorized as a "Code quality rule" in our ESLint config file, but seems to be more of a stylistic thing. The easiest thing might be to drop the rule, at least for static-site.

[jameshadfield]

We should use it but allow function hoisting (see this thread). Most of those errors are from a (formerly? currently?) recommended react style along the lines of:

export const Component = (props) => {
   return (<Container>jsx</Container>)
}
const Container = styled.div``

which looks like is shouldn't work (it works, I think, because Component isn't called by that file, rather it's imported elsewhere so that Container is in scope by the time it runs).

[victorlin]

I've pushed 95b0ec0 to address this. It covers everything, but not sure if it's the best approach.

[victorlin]

Task: address operator-linebreak violations

There are 16. Example:

static-site/src/components/sourceInfoHeading.jsx
   96:31  error  '&&' should be placed at the beginning of the line  operator-linebreak
  102:28  error  '&&' should be placed at the beginning of the line  operator-linebreak

This was added per nextstrain/auspice#1665 (comment). It's a code style rule, I'm ambivalent to dropping or addressing.

[victorlin]

Task: address quote-props violations

There are 7. Example:

static-site/src/components/People/teamMembers.js
    2:3  error  Unnecessarily quoted property 'founders' found  quote-props
   16:3  error  Unnecessarily quoted property 'core' found      quote-props
   85:3  error  Unnecessarily quoted property 'alumni' found    quote-props
  152:3  error  Unnecessarily quoted property 'board' found     quote-props

This was added per nextstrain/auspice#1665 (comment). It's a code style rule, I'm ambivalent to dropping or addressing.

[genehack]

I would say that maybe the time for this is after the App Router conversion is finished, rather than in the middle of it?

[victorlin]

@genehack sure, I've updated the PR description and will plan to leave this in draft until that's done.