Use anchor for resource links #773
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous "links" relied on onClick which is bad for accessibility. If div is still desired, the link role would be appropriate.¹ Or, use an anchor element instead, as done in this commit. ¹ <https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/link_role>
nextstrain-bot
temporarily deployed
to
nextstrain-s-victorlin--qtfpsm
victorlin
commented
Jan 3, 2024
Comment on lines
+122
to
+124
| function formatDataset(requestPath) { | ||
|
|
||
| // FIXME: Do we actually need dispatch and changePage here? I've removed them for now. |
There was a problem hiding this comment.
This is my main concern - it's not clear to me what dispatch and changePage were used for. Seems to work fine without it.
There was a problem hiding this comment.
The behaviour will be a little different -- dispatching stays within the SPA, whereas links will go to a new URL, fetch the auspice HTML entrypoint, fetch the auspice JS (cache hit), reparse the JS and so on. In practice, the Auspice splash page within nextstrain.org is used rarely - perhaps only for community data?
P.S. I've wanted proper link behaviour for a while now, especially in the default Auspice splash page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The previous "links" relied on onClick which is bad for accessibility. If div is still desired, the link role would be appropriate.¹ Or, use an anchor element instead, as done in this commit.
¹ https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/link_role
Related issue(s)
N/A
Checklist