-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sitemap to footer #868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @victorlin! I haven't thought too hard about the entries in each list but as a v1 it looks great.
This will be a nice improvement! Aesthetically, one thing I'd point out (in addition to what James did) is that the alignment/justification of the sitemap as a whole and the columns within it feel a bit off to me. Our central layout element/block is a centered column, but we have a slew of widths for that column. Within the column, text and inline elements are either centered or left-justified. I think the sitemap would "fit in" better with the rest of the page blocks with a reduced overall width (e.g. what the team block uses) and/or with the inner columns/blocks of the sitemap (Resources, Tools, etc) themselves centered (but keeping the text elements within them still left-justified). Something like the below. |
b4727b1
to
ce165a8
Compare
With the new sitemap at the top of the footer, it makes more sense to render this on not only GenericPage but also pages that use Splash.
ce165a8
to
69c3b5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @victorlin! (A rebase onto master might be nice before merge, but not required)
Thanks for reviewing! There's no merge conflicts and #869 is based on this, so I'll just merge as-is to avoid extra rebase churn on that PR. |
preview on contact page
Description of proposed changes
Adds links to the footer.
Related issue(s)
Checklist
Check if changes affect the resource index JSON revision