Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev environment + Typescript + Variables Improvements #5

Merged
merged 13 commits into from
Jul 3, 2023
Merged

Dev environment + Typescript + Variables Improvements #5

merged 13 commits into from
Jul 3, 2023

Conversation

zsteinkamp
Copy link
Contributor

  • Ergonomics for dev environment (added node container to docker-compose along with VSCode devcontainer support)
  • Hacking away at Typescript conformance
  • Added prettier for automatic code formatting
  • Utility methods targeting variables, with the intent of allowing the use of Nginx or environment variables for all configurable things.

@zsteinkamp zsteinkamp marked this pull request as draft June 15, 2023 23:52
Dockerfile Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ivanitskiy
Copy link
Contributor

LGTM with a few minor comments.

@ivanitskiy
Copy link
Contributor

I see a missing part here, an updated examples/nginx.conf file, which documents all newly introduced (request)variables and associated env var and their respective defaults.

src/utils.ts Show resolved Hide resolved
README.md Show resolved Hide resolved
@ryepup ryepup mentioned this pull request Jun 30, 2023
.dockerignore Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
…e Array.from polyfill to its own .js file since .ts was not happy with that code; put versions back in Dockerfiles
@zsteinkamp zsteinkamp changed the title WIP: Dev environment + Typescript + Variables Improvements Dev environment + Typescript + Variables Improvements Jul 3, 2023
@zsteinkamp zsteinkamp requested review from ivanitskiy and ryepup July 3, 2023 15:17
@zsteinkamp zsteinkamp marked this pull request as ready for review July 3, 2023 15:17
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@ivanitskiy ivanitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rock and roll! Thank you for your contribution!

@ivanitskiy ivanitskiy merged commit 197b39b into nginx:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants