update type response

ngocle2497 · Jul 11, 2022 · 5d014be · 5d014be
1 parent 842cacf
commit 5d014be
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 8 deletions.
diff --git a/template/src/app/common/method/index.ts b/template/src/app/common/method/index.ts
@@ -55,6 +55,19 @@ export const propsToStyle = <T = Record<string, number | string>>(
     }, {} as Record<string, number | string>);
 };
 
+/**
+ * return true when success and false when error
+ */
+ export const handleErrorResponse = (
+  response: ResponseBase<any>,
+): response is ResponseBase<any, true> => {
+  if (!response.status) {
+    // TODO: handle error
+    return false;
+  }
+  return true;
+};
+
 export const execFunc = <Fn extends (...args: any[]) => any>(
   func?: Fn,
   ...args: Parameters<Fn>

diff --git a/template/src/app/config/type.ts b/template/src/app/config/type.ts
@@ -1,13 +1,17 @@
-export interface ResponseBase<T = Record<string, unknown>> {
+export type ResponseBase<T = any, TStatus = boolean> = {
   code: number;
+} & (TStatus extends true
+  ? {
+      data: T;
 
-  msg?: string | null;
+      status: true;
+    }
+  : {
+      status: false;
 
-  data?: T;
-
-  status: boolean;
-}
+      msg?: string |null;
 
+    });
 export interface ParamsNetwork {
   url: string;
   params?: Record<string, string | number>;

diff --git a/template/src/app/library/networking/helper.ts b/template/src/app/library/networking/helper.ts
@@ -14,7 +14,6 @@ const responseDefault: ResponseBase<Record<string, unknown>> = {
   code: -500,
   status: false,
   msg: translate('error:errorData'),
-  data: {},
 };
 
 export const onPushLogout = async () => {
@@ -28,7 +27,7 @@ export const handleResponseAxios = <T = Record<string, unknown>>(
   res: AxiosResponse<T>,
 ): ResponseBase<T> => {
   if (res.data) {
-    return { code: CODE_SUCCESS, status: true, data: res.data, msg: null };
+    return { code: CODE_SUCCESS, status: true, data: res.data, };
   }
   return responseDefault as ResponseBase<T>;
 };

diff --git a/template/src/app/redux/listener/login.ts b/template/src/app/redux/listener/login.ts
@@ -1,3 +1,4 @@
+import { handleErrorResponse } from '@common'
 import { takeLatestListeners } from '@listener';
 import { ApiConstants, NetWorkService } from '@networking';
 
@@ -16,5 +17,8 @@ takeLatestListeners(true)({
     if (!response) {
       return;
     }
+    if (handleErrorResponse(response)) {
+      // TODO: do something when login success
+    }
   },
 });