Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #4306 Update glob version to fix compatibility issues #4308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ansh7432
Copy link

Fixed deprecation warnings in glob version and updated the node version to make it compatible
please review it

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ansh7432 ansh7432 changed the title Update glob version to fix compatibility issues Fix #4308 Update glob version to fix compatibility issues Nov 20, 2024
@ansh7432 ansh7432 changed the title Fix #4308 Update glob version to fix compatibility issues Fix issue #4306 Update glob version to fix compatibility issues Nov 20, 2024
@garg3133
Copy link
Member

@ansh7432 dependencies and devDependencies are two different and important parts of the package.json file, so we cannot just remove something from dependencies and put it into devDependencies.

dependencies are what gets installed on the user's computer and devDependencies (along with dependencies) are what gets installed on the developer's computer who is working on the particular package.

Also, nightwatch shouldn't be a part of devDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants