Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Guess open linear transform formats #160

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Conversation

oesteban
Copy link
Collaborator

@oesteban oesteban commented Mar 1, 2022

EAFP implementation of loading linear transforms without specifying the format of the file.

Resolves: #86.
Resolves: #87.
Resolves: #107.

EAFP implementation of loading linear transforms without specifying the
format of the file.

Resolves: #86.
Resolves: #87.
Resolves: #107.
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #160 (bb8bf32) into master (4d4e3d9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          13       13           
  Lines        1208     1208           
  Branches      184      184           
=======================================
  Hits         1191     1191           
  Misses         10       10           
  Partials        7        7           
Flag Coverage Δ
travis 96.77% <97.77%> (ø)
unittests 98.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nitransforms/io/__init__.py 100.00% <100.00%> (ø)
nitransforms/io/afni.py 98.33% <100.00%> (+0.04%) ⬆️
nitransforms/io/base.py 100.00% <100.00%> (ø)
nitransforms/io/fsl.py 91.74% <100.00%> (ø)
nitransforms/io/itk.py 100.00% <100.00%> (ø)
nitransforms/linear.py 96.82% <100.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1f125...bb8bf32. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Mar 2, 2022

Hello @oesteban! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-03-02 08:27:32 UTC

@oesteban oesteban force-pushed the enh/autoload-linear branch from 56044ea to 1fa7eeb Compare March 2, 2022 06:49
@oesteban oesteban marked this pull request as ready for review March 2, 2022 07:13
@oesteban oesteban requested a review from effigies March 2, 2022 08:22
@oesteban oesteban force-pushed the enh/autoload-linear branch from 11d96cb to bb8bf32 Compare March 2, 2022 08:27
@oesteban
Copy link
Collaborator Author

oesteban commented Mar 2, 2022

Hey @effigies, just FYI, I requested your review. It'd be nice to have your feedback esp. regarding error types. Since the interim report is out, this is not urgent anymore - so whenever you feel you have the availability/energy.

This does not introduce any major changes to the code, so an alternative route is to postpone deep review for #110.

@oesteban
Copy link
Collaborator Author

@effigies do you want to bump this?

Also a good warming up for @mgxd, now he's returning :)

@effigies
Copy link
Member

Sorry, yes, I'll try to get back to this this week.

@oesteban
Copy link
Collaborator Author

oesteban commented Apr 4, 2022

Bumping up

@oesteban
Copy link
Collaborator Author

Any chance to get more eyes on this? @mgxd @effigies

@oesteban oesteban merged commit 1a34ccc into master Apr 28, 2022
@oesteban oesteban deleted the enh/autoload-linear branch April 28, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants