added necessary steps for running code coverage check job

niwciu · Nov 13, 2024 · 3c360e8 · 3c360e8
1 parent 7dc27c1
commit 3c360e8
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 8 deletions.
diff --git a/.github/workflows/CI_pipeline.yml b/.github/workflows/CI_pipeline.yml
@@ -87,6 +87,7 @@ jobs:
             uses: actions/download-artifact@v4
             with:
               name: modbus_unit_tests_app
+
           - name: Run Unit Tests
             run: |
               chmod +x modbus_test
@@ -99,11 +100,24 @@ jobs:
         steps:
             - name: checkout
               uses: actions/checkout@v4
+
+            - name: Download Unit Tests Build Artifacts
+              uses: actions/download-artifact@v4
+              with:
+                name: modbus_unit_tests_app
+                path: test/modbus/out
+
             - name: Run Unit Tests
               continue-on-error: true
-              run:  arm-none-eabi-gcc --version     # This step will fail
-            - name: Check Code Coverage
-              run: echo "test"                      # This step will not fail
+              working-directory: test/modbus/out
+              run: |
+                chmod +x modbus_test
+                ./modbus_test -v
+
+            - name: Check Test Coverage
+              uses: threeal/[email protected]
+              with:
+                fail-under-line: 90
 
     run_cppcheck:
         name: Run CppCheck

diff --git a/test/modbus/slave_RTU_test.c b/test/modbus/slave_RTU_test.c
@@ -280,10 +280,10 @@ TEST(Slave_RTU_test, GivenModbusSlaveInitAndReadCoilsReqWithProperSlaveIdAndProp
     TEST_ASSERT_EQUAL(MODBUS_SLAVE_IDLE, slave_manager_state_machine);
 }
 
-TEST(Slave_RTU_test, test)
-{
-    TEST_FAIL_MESSAGE("ADDED_NEW_TEST")
-}
+// TEST(Slave_RTU_test, )
+// {
+//     TEST_FAIL_MESSAGE("ADDED_NEW_TEST")
+// }
 
 // TEST(Slave_RTU_test, )
 // {

diff --git a/test/modbus/slave_RTU_test_runner.c b/test/modbus/slave_RTU_test_runner.c
@@ -19,7 +19,7 @@ TEST_GROUP_RUNNER(Slave_RTU_test)
     RUN_TEST_CASE(Slave_RTU_test, GivenModbusSlaveInitAndReadCoilsReqWithProperSlaveIdAndProperCrcRecivedAndTimer1_5CharTrigerAndTimer3_5CharTrigerThenSlavePrepareRespond);
     RUN_TEST_CASE(Slave_RTU_test, GivenModbusSlaveInitAndReadCoilsReqWithProperSlaveIdAndProperCrcRecivedAndTimer1_5CharTrigerAndTimer3_5CharTrigerThenSlaveSendRespAndGoToModbuSlaveTransmitingResp);
     RUN_TEST_CASE(Slave_RTU_test, GivenModbusSlaveInitAndReadCoilsReqWithProperSlaveIdAndProperCrcRecivedAndTimer1_5CharTrigerAndTimer3_5CharTrigerAndSlaveSendingRespWhenWholeRespSendThenInitMsgBuffAndGoToIdleState);
-    RUN_TEST_CASE(Slave_RTU_test, test);
+    // RUN_TEST_CASE(Slave_RTU_test, );
     //    RUN_TEST_CASE(Slave_RTU_test, );
     //    RUN_TEST_CASE(Slave_RTU_test, );
     //    RUN_TEST_CASE(Slave_RTU_test, );