enh: add a list of known nvidia drivers as an attr in nixGL #131
Conversation
This can be used to generate wrappers purely and programmatically inside of flakes
|
I like this! Just had to spend 2 hours or so updating a fork of this code because my distro updated my nvidia driver to 530. Although it now needs |
| subprocess.check_output(["nix-store", "--delete", store_pth]) | ||
| print("Cleanup success.") |
There was a problem hiding this comment.
Why not just run nix-collect-garbage?
There was a problem hiding this comment.
in my own nix use I'm not very careful with my gcroots and would prefer the gc not be run unless I do it explicitly. Do you see advantages to using that instead?
There was a problem hiding this comment.
It just feels unnecessary if there are easier ways.
There was a problem hiding this comment.
do you mean running nix-collect-garbage after downloading each runfile? If so I don't see if as much of an improvement and may inadvertently gc something unintended.
If you mean wait until the end of the script and then call gc, if so that's probably a bit faster, the store deletion adds some overhead to the download loop, but still runs the risk of gc'ing something unintended. Further the runfiles are now quite large and on computers with limited space waiting to the end to gc might not be best, this was why I wrote this in in the first place.
If you mean leave it up to the user to GC or not after running this script, that sounds good, suffers the space issue noted above, but in most contexts, especially with incremental downloading is probably fine.
There was a problem hiding this comment.
do you mean running nix-collect-garbage after downloading each runfile? If so I don't see if as much of an improvement and may inadvertently gc something unintended.
Just once in the end if desired and I would be willing to accept that.
I mean if you really want to keep it, I don't have a problem with it, I just wanted to check if you just were searching for that command or so.
There was a problem hiding this comment.
I'm happy with this approach; it seems more fine-grained and more performant than calling nix-collect-garbage, and you could always disabled cleanup and call the gc yourself if preferred.
|
Now that this project has moved to nix-community, is anyone with commit rights able to say if they'd be interested in ever merging this? I'm maintaining the branch for my own projects, no need to leave the PR open if this addition isn't desirable for the nixGL userbase at large. |
|
Hello! Is there any way for me to help let this PR get merged? |
This can be used to generate wrappers purely and programmatically inside of flakes.
There's a script I used to generate the version/hash pairs in the list, see the included readme for more details.