Solaris: fixes build and tests, adds CI #2544
Open
+64
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
reviewed
Nov 20, 2024
| /// let fds = [r.as_raw_fd()]; | ||
| /// let cmsg = ControlMessage::ScmRights(&fds); | ||
| /// sendmsg(fd.as_raw_fd(), &iov, &[cmsg], MsgFlags::empty(), Some(&localhost)).unwrap(); | ||
| /// sendmsg(fd.as_raw_fd(), &iov, &[], MsgFlags::empty(), Some(&localhost)).unwrap(); |
There was a problem hiding this comment.
Are there any control messages we can use on Solaris?
There was a problem hiding this comment.
So there is no control message we can use? 👀
Update: I just checked enum ControlMessage, looks like this ScmRights is available on Solaris, any reason to remove it?
There was a problem hiding this comment.
@psumbera What about this one? 👀
|
BTW, looks like |
psumbera
force-pushed
the
solaris-fixes
branch
2 times, most recently
from
0aaaff7
to
429af01
Compare
psumbera
force-pushed
the
solaris-fixes
branch
2 times, most recently
from
28fe095
to
884888f
Compare
|
Hurd CI failure seems to be related to rust-lang/libc#3785. |
Right, std is broken due to that PR I just sent a patch to the std: rust-lang/rust#133515 |
|
I just disabled the Hurd CI, you can rebase your branch to fix the issue:) |
psumbera
force-pushed
the
solaris-fixes
branch
2 times, most recently
from
ae38724
to
96856f1
Compare
Disables some tests for Solaris. test/test_sendfile.rs: Solaris, sendfilev() doesn't support AF_UNIX sockets. Instead, it expects an AF_INET or AF_INET6 sockets. test/sys/test_timer.rs: Note that sys::test_timer::alarm_fires can fail as timer_create(3C) function requires the PRIV_PROC_CLOCK_HIGHRES. But since tests are supposed to run with sudo it should be ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables some tests for Solaris.
test/test_sendfile.rs:
Solaris, sendfilev() doesn't support AF_UNIX sockets. Instead, it expects an AF_INET or AF_INET6 sockets.