Skip to content

Commit

Permalink
doc: update link for landing PRs
Browse files Browse the repository at this point in the history
The onboarding doc links to the "Technical How-to" portion of the
Collaborator's Guide for landing PRs. That section is a subsection of
the "Landing Pull Requests" portion of that document. By skipping the
main section header, important information is skipped, such as the part
about not using the merge button and descriptions of the metadata
required. Update the link to target the main section and not the
subsection.

PR-URL: #12415
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
  • Loading branch information
Trott authored and MylesBorins committed May 18, 2017
1 parent 81b5350 commit 1c1269d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion doc/onboarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ onboarding session.

## Landing PRs

* [See the Collaborator Guide: Technical HOWTO](https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#technical-howto)
* [See the Collaborator Guide: Landing Pull Requests](https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#landing-pull-requests)

## Exercise: Make a PR adding yourself to the README

Expand Down

0 comments on commit 1c1269d

Please sign in to comment.