test: use unusual chars in the path to ensure our tests are robust #48409
Conversation
|
Review requested:
|
nodejs-github-bot
added
the
meta
|
TIL GNU Make does not support files containing whitespaces nor |
|
Should we maybe avoid the hidden characters? I guess it's ok if GH only warns about them now but I don't want to see a permanent warning on the repo. |
I'm pretty sure it's just about the branch name for this PR, not related to the content of this PR. console.log("\u2020\u00A3\u00A7\u2122" === '†£§™'); // true |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48409 +/- ##
==========================================
- Coverage 88.54% 88.53% -0.01%
==========================================
Files 657 657
Lines 190290 190296 +6
Branches 36533 36532 -1
==========================================
- Hits 168488 168482 -6
+ Misses 14984 14979 -5
- Partials 6818 6835 +17
|
aduh95
force-pushed
the
†£§™
branch
3 times, most recently
from
a5e5921 to
c8b19c2
Compare
aduh95
force-pushed
the
†£§™
branch
2 times, most recently
from
78ec699 to
1c336ad
Compare
aduh95
force-pushed
the
†£§™
branch
3 times, most recently
from
34bafc0 to
522b401
Compare
| - name: Test | ||
| run: make run-ci -j4 V=1 TEST_CI_ARGS="-p actions --node-args='--test-reporter=spec' --node-args='--test-reporter-destination=stdout' --measure-flakiness 9" | ||
| run: make -C node run-ci -j4 V=1 TEST_CI_ARGS="-p actions --node-args='--test-reporter=spec' --node-args='--test-reporter-destination=stdout' --measure-flakiness 9" | ||
| - name: Re-run test in a folder whose name contains unusual chars |
There was a problem hiding this comment.
Wouldn't it mean we'll double the time to run the tests in the GH Actions?
There was a problem hiding this comment.
As you see in this PR, it adds about 10 minutes (a bit less on Linux)
When the source map data are invalid json strings, skip construct SourceMap on it. Additionally, suppress exceptions on source map lookups and fix test runners crash on invalid source maps.
Only invalidates source map lookup cache when a new source map is found. This improves when user codes interleave with builtin functions, like `array.map`.
Hopefully our tests should work without assuming the repo is cloned in path that contains unusual chars.