test: convert readdir test to use test runner #55750
Merged
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
pmarchini
reviewed
Nov 6, 2024
pmarchini
added
the
code-and-learn
tchetwin
force-pushed
the
test-refactor
branch
2 times, most recently
from
9857f8e
to
f2fe5a5
Compare
RedYetiDev
reviewed
Nov 6, 2024
tchetwin
force-pushed
the
test-refactor
branch
from
f2fe5a5
to
6a7fa7b
Compare
pmarchini
approved these changes
Nov 7, 2024
RedYetiDev
reviewed
Nov 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55750 +/- ##
==========================================
+ Coverage 88.40% 88.41% +0.01%
==========================================
Files 654 654
Lines 187747 187757 +10
Branches 36127 36131 +4
==========================================
+ Hits 165972 166009 +37
+ Misses 15009 14998 -11
+ Partials 6766 6750 -16
|
Signed-off-by: tchetwin <[email protected]>
tchetwin
force-pushed
the
test-refactor
branch
from
6a7fa7b
to
7598397
Compare
RedYetiDev
approved these changes
Nov 8, 2024
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Nov 23, 2024
pmarchini
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e92499c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of a code & learn session at NodeConf EU 2024 in Waterford, Ireland.
It was part of a wider initiative to update Node.js tests to make use of the new built-in test apparatus.