doc: fixing the crc32 function on documentation #55898
Open
+61
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
kevinuehara
force-pushed
the
kevinuehara/fix-slib-crc32
branch
from
af64b4e
to
faff065
Compare
lpinca
reviewed
Nov 17, 2024
kevinuehara
force-pushed
the
kevinuehara/fix-slib-crc32
branch
from
94a1bbf
to
c376eba
Compare
|
Why was I pinged? |
|
@RedYetiDev Sorry! I pinged you because you commented on the previous PR closed |
lpinca
reviewed
Nov 19, 2024
lpinca
approved these changes
Nov 21, 2024
lpinca
added
the
commit-queue-squash
kevinuehara
force-pushed
the
kevinuehara/fix-slib-crc32
branch
from
04837f8
to
fb8cac4
Compare
jasnell
reviewed
Nov 23, 2024
|
|
||
| Provides an object enumerating Zlib-related constants. | ||
|
|
||
| ## `zlib.crc32(data[, value])` |
There was a problem hiding this comment.
While I notice the zlib.constants is not in alphabetical order here, the zlib.crc32(...) section should likely be moved up to appear before zlib.flush(...)
There was a problem hiding this comment.
@jasnell Isn't the point of this PR that zlib.crc32 is not a subsection of zlib.ZlibBase, but a section on the same level as zlib.constants? I think it's alphabetically sorted correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm adjusing the documentation of zlib. The crc32 is not a method of ZlibBase. It is a standalone function of the module.
Mentioned in 55800
@RedYetiDev @ErickWendel @aduh95