lib: clean up persisted signals when they are settled #56001
+61
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeksilva97
force-pushed
the
abort-controller-mem-leak
branch
from
bd8fe65
to
e152212
Compare
geeksilva97
changed the title
geeksilva97
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56001 +/- ##
=======================================
Coverage 87.95% 87.96%
=======================================
Files 656 656
Lines 188310 188325 +15
Branches 35963 35975 +12
=======================================
+ Hits 165630 165657 +27
+ Misses 15854 15842 -12
Partials 6826 6826
|
atlowChemi
approved these changes
Nov 27, 2024
github-actions
bot
removed
the
request-ci
aduh95
added
the
author ready
jazelly
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Not blocking, but looks like this fixed the repro reported by the OP, but not the one mentioned at #55328 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #55328
Fixes #55328
This PR adds a finalizer to the non-composed signals used in
AbortSignal.any. With that finalizer, those settled signals can be removed fromgcPersistentSignals.Comparison
This comparison shows that settled signals are being collected.