Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: fix parsing messages with splitted length field #56106

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MGorkov
Copy link

@MGorkov MGorkov commented Dec 2, 2024

Fixes: #55834

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Dec 2, 2024
@juanarbol
Copy link
Member

Hey! Amazing, nice patch, thank you.

Could you please add a test for it?

@MGorkov
Copy link
Author

MGorkov commented Dec 10, 2024

@juanarbol I've written a test where the child process sends messages to the main, and the third message is split into parts so that the header with the length of the message is split too, which leads to the problem in the current version but my patch solves it

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (61e4ad5) to head (a7ef03a).
Report is 104 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56106      +/-   ##
==========================================
+ Coverage   88.01%   88.53%   +0.51%     
==========================================
  Files         656      657       +1     
  Lines      188982   190208    +1226     
  Branches    35997    36527     +530     
==========================================
+ Hits       166330   168396    +2066     
+ Misses      15825    14995     -830     
+ Partials     6827     6817      -10     
Files with missing lines Coverage Δ
lib/internal/child_process/serialization.js 95.85% <100.00%> (+0.12%) ⬆️

... and 140 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hang up with 'advanced' IPC deserialization
4 participants