Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: include poor-performance diagnostic #4928

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

RafaelGSS
Copy link
Member

Reference: nodejs/diagnostics#502

cc: @nodejs/diagnostics

RafaelGSS added a commit to RafaelGSS/diagnostics that referenced this pull request Nov 10, 2022
RafaelGSS added a commit to RafaelGSS/diagnostics that referenced this pull request Nov 10, 2022
@gireeshpunathil
Copy link
Member

@RafaelGSS - is it a doc migration from the internal diagnostic repo to the nodes.org site? (knowing that helps avoiding potential detailed review)

@RafaelGSS
Copy link
Member Author

@RafaelGSS - is it a doc migration from the internal diagnostic repo to the nodes.org site? (knowing that helps avoiding potential detailed review)

Yes

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS merged commit 173eba1 into nodejs:main Nov 15, 2022
RafaelGSS added a commit to nodejs/diagnostics that referenced this pull request Nov 15, 2022
SEWeiTung added a commit that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants