ES: Translation for security #4932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @nodejs/nodejs-es , plz have a review. |
vrunoa
reviewed
Nov 13, 2022
vrunoa
reviewed
Nov 13, 2022
vrunoa
reviewed
Nov 14, 2022
|
@AugustinMauroy I know you have the best intentions with your LGTM, but if you're not part of the Website WG or not a Spanish translator, avoid stamping LGTM's as it gives a wrong impression that this PR got approved 🙈 |
suggested by @vrunoa in 4932
|
Thanks for the suggestions @vrunoa! 🙌 |
Merged
Propagate changes from #4941
eafelix
approved these changes
Nov 16, 2022
Propagate changes from #4951
|
Can we merge it? :) |
vrunoa
approved these changes
Nov 24, 2022
|
@UlisesGascon I think someone from @nodejs/website still needs to approve it ? or maybe @nodejs/translators ? |
|
mmm... not sure, first time I do a translation 🤔 |
ovflowd
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR to do a full page translation. I am not sure 100% for some terms translation to Spanish but I tried to be very literal and I keep some english terms that are hard to translate to proper Spanish.
Please review it @nodejs/nodejs-es 🙏
Main changes
locale/es/docs/guides/index.mdto matchlocale/en/docs/guides/index.mdcontentContext