Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working version of the websocket support #3514

Open
wants to merge 9 commits into
base: dev-esp32
Choose a base branch
from
Open

Working version of the websocket support #3514

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ec604d9
Mostly working version of the websocket support
pjsg Mar 11, 2022
e0748a4
Improved the documentation
pjsg Apr 30, 2022
75fdcd9
Make it compile without websocket support
pjsg Apr 30, 2022
ff116b7
Minor cleanup
pjsg May 2, 2022
6899d8e
Better handling of lifetime of WS object
pjsg May 3, 2022
2280953
Remove the printf debugging
pjsg May 4, 2022
7cf7f4c
Merge remote-tracking branch 'origin/dev-esp32' into http-ws
pjsg Feb 1, 2024
e88b23e
Clean up and add more debug (normally compiled out)
pjsg Feb 2, 2024
affed3f
FIx the example to use a correct value
pjsg Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/modules/httpd.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ configured.
httpd.start({
webroot = "<static file prefix>",
max_handlers = 20,
auto_index = httpd.INDEX_NONE || httpd.INDEX_ROOT || httpd.INDEX_ALL,
auto_index = httpd.INDEX_ALL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the mention of the other index modes, I can't say I'm in favour of that 🙃

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out that these are actually enums and shouldn't be or'ed together. Worse, the example uses || which is the logical or. Thus, this expression returns the first non-zero value!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, logical OR, because you need to choose one of them. What's the correct syntax for that in this case, if not that? (genuine question, not a snarky comment)

})
```

Expand Down Expand Up @@ -288,7 +288,7 @@ nil
httpd.start({
webroot = "<static file prefix>",
max_handlers = 20,
auto_index = httpd.INDEX_NONE + httpd.INDEX_ROOT + httpd.INDEX_ALL,
auto_index = httpd.INDEX_ALL,
})

function echo_ws(req, ws)
Expand Down
Loading