Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using multiple memory slots in rmt setup #3568

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

pjsg
Copy link
Member

@pjsg pjsg commented Feb 8, 2023

Fixes #3567 .

Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.

  • This PR is for the dev branch rather than for the release branch.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

I added the slots parameter to configure the amount of memory that is used by the sender or receiver. This can be up to 8 on the regular ESP32, but is smaller on other platform. An error will be thrown if the request cannot be honored.

Copy link
Member

@jmattsson jmattsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments around optionality, looks good to me 👍

components/modules/rmt.c Show resolved Hide resolved
components/modules/rmt.c Show resolved Hide resolved
@pjsg pjsg merged commit 4816c16 into nodemcu:dev-esp32 Feb 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants