Issue restart rather than second lua_main() call on LFS reload. #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By the time we get informed that there's an LFS reload we've already opened all the user libraries as well, so it's not safe to simply redo that with a new lua_State. Currently that results in a hang, and a manual reset is required to progress. Doing the automatic restart is the correct approach here, even though this adds another reboot to the LFS reload process. Also fixed up a couple of minor issues when embedded-LFS is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the time we get informed that there's an LFS reload we've already opened all the user libraries as well (and run their init code), so it's not safe to simply redo that with a fresh lua_State without also starting with a fresh hardware state. Currently attempting to do the second lua_main() call results in a hang, and a manual reset is required to progress. Doing the automatic restart is the correct approach here, even though this adds another reboot to the LFS reload process.
Also fixed up a couple of minor issues when embedded-LFS is used.
Fixes #3667.
dev-esp32branch rather than for thereleasebranch.docs/*.