thoas#50 Fix tests

noppakorn-wai · Mar 10, 2021 · 442500c · 442500c
1 parent a365a2b
commit 442500c
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/chain_builder_test.go b/chain_builder_test.go
@@ -1012,6 +1012,11 @@ func TestChainReduce(t *testing.T) {
 			ReduceFunc: '*',
 			Acc:        1,
 		},
+		{
+			In:         []string{"1", "2", "3", "4"},
+			ReduceFunc: func(acc string, elem string) string { return acc + elem },
+			Acc:        "",
+		},
 	}
 
 	for idx, tc := range testCases {

diff --git a/lazy_builder_test.go b/lazy_builder_test.go
@@ -1012,6 +1012,11 @@ func TestLazyReduce(t *testing.T) {
 			ReduceFunc: '*',
 			Acc:        1,
 		},
+		{
+			In:         []string{"1", "2", "3", "4"},
+			ReduceFunc: func(acc string, elem string) string { return acc + elem },
+			Acc:        "",
+		},
 	}
 
 	for idx, tc := range testCases {

diff --git a/reduce_test.go b/reduce_test.go
@@ -12,19 +12,19 @@ func TestReduce(t *testing.T) {
 		Arr    interface{}
 		Func   interface{}
 		Acc    interface{}
-		Result float64
+		Result interface{}
 	}{
 		{
 			[]int{1, 2, 3, 4},
-			func(acc, elem int) int { return acc + elem },
+			func(acc, elem float64) float64 { return acc + elem },
 			0,
 			float64(10),
 		},
 		{
 			&[]int16{1, 2, 3, 4},
 			'+',
 			5,
-			float64(15),
+			int16(15),
 		},
 		{
 			[]float64{1.1, 2.2, 3.3},
@@ -36,14 +36,20 @@ func TestReduce(t *testing.T) {
 			&[]int{1, 2, 3, 5},
 			func(acc int8, elem int16) int32 { return int32(acc) * int32(elem) },
 			1,
-			float64(30),
+			int32(30),
 		},
 		{
 			[]interface{}{1, 2, 3.3, 4},
 			'*',
 			1,
 			float64(26.4),
 		},
+		{
+			[]string{"1", "2", "3", "4"},
+			func(acc string, elem string) string { return acc + elem },
+			"",
+			"1234",
+		},
 	}
 
 	for idx, test := range testCases {