-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add associative scan #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Associative scan takes vectorised operators (given that the operations across the leaves of the computational tree are batched).
Update: |
Ok I fixed the maths! At the cost of doubling the number of Next step is to add |
Finished the speedup comparison with and without associative scan and adapted the handling of random keys in |
Be sure to add the underscore to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
First attempt at using
jax.lax.associative_scan
#14 , but it's throwing a matmul contracting dimensions error and I'm not sure why.