Add reproducible code for matrix exponential simulations #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaelanDt
reviewed
Jul 19, 2024
KaelanDt
reviewed
Jul 22, 2024
examples/matrix_exponentials/run.py
Outdated
|
|
||
|
|
||
| D = [64, 128, 256, 512] | ||
| ERR_abs = np.zeros((args.n_repeats, len(D), NT)) |
There was a problem hiding this comment.
mixing uppercase and lowercase not very clean
There was a problem hiding this comment.
Changed ERR to err, I think the rest is ok
| return A_wishart | ||
|
|
||
|
|
||
| def orthogonal(d: int, _) -> jnp.ndarray: |
There was a problem hiding this comment.
why the second _ argument?
There was a problem hiding this comment.
Unified signature with wishart but ortho_group is a scipy function that doesn't use jax random keys
|
|
||
|
|
||
| def wishart(d: int, key: random.PRNGKey) -> jnp.ndarray: | ||
| n = 2 * d # degrees of freedom |
There was a problem hiding this comment.
Comments seem a bit random in the scripts
There was a problem hiding this comment.
I think this one is ok haha have cleaned up run.py
KaelanDt
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducible code for the experiments in https://arxiv.org/abs/2311.12759