-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove additional signal calls in websockify that causes novnc to hang. #219
Conversation
@kanaka kindly see if this works. Since the description is long, I did commit thrice as the message description was not aligning proper spaces. |
@DirectXMan12 sounds good and thanks since you guys have admin access. :) |
This may also fix the issue I submittedL |
@kanaka @DirectXMan12 : Can you please help for merging the same? |
squashed and merge into a single commit for my change. |
Openstack nova novnc-proxy services uses websockify to provide support for nova vms using novnc proxy. At present, novnc hangs every couple of weeks. It only resumes post restart of the novnc-proxy which is not good. Hence, this code in websockify is updated to get rid of additional signal calls to avoid novnc going in hang state even though process is running. Basically, we are getting rid of existing msg and vmsg calls in the websocket.py. This is kind of quick fix but we will need an additional way of figuring out the logging to make it easy to trace in case of any further failures in future. closes bug: novnc/noVNC#556
@DirectXMan12 and @kanaka any updates on this? :( |
LGTM |
Sweet. 👍 |
Remove logging in signal handlers
Openstack nova novnc-proxy services uses websockify to provide support
for nova vms using novnc proxy. At present, novnc hangs every couple of
weeks. It only resumes post restart of the novnc-proxy which is not
good. Hence, this code in websockify is updated to get rid of additional
signal calls to avoid novnc going in hang state even though process is
running. Basically, we are getting rid of existing msg and vmsg calls in
the websocket.py. This is kind of quick fix but we will need an
additional way of figuring out the logging to make it easy to trace in
case of any further failures in future.
closes bug: novnc/noVNC#556