chore: clarify comment about obsolete prefixes #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an explanation why the "=" and "v" prefixes should not be used anymore.
ljharb
reviewed
Nov 29, 2024
|
This now says two contradictory things.
|
ljharb
reviewed
Dec 2, 2024
| @@ -141,6 +141,8 @@ A "version" is described by the `v2.0.0` specification found at | |||
| <https://semver.org/>. | |||
|
|
|||
| A leading `"="` or `"v"` character is stripped off and ignored. | |||
| A leading "v" is kept for compatibility with `v1.0.0` of the SemVer | |||
There was a problem hiding this comment.
Suggested change
| A leading "v" is kept for compatibility with `v1.0.0` of the SemVer | |
| Support for stripping a leading "v" is kept for compatibility with `v1.0.0` of the SemVer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an explanation why the "=" and "v" prefixes should not be used anymore.