Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): improve local registry script… #29050

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tinesoft
Copy link
Contributor

@tinesoft tinesoft commented Nov 23, 2024

… output

Current Behavior

The startLocalRegistry() always assumed that the local registry was started on localhost , which is not necessary the case, if for example user has set the listenAddress option in the underlying verdaccio executor or via the verdaccio config file

const listenAddress = options.listenAddress

As a result the startLocalregistry(), will never return as, it is waiting forever to detect the local registry URL in the process output:

if (data.toString().includes('http://localhost:')) {

Expected Behavior

Allow customizing the listenAddress when starting the local registry, via an additional option that can be provided when calling the method. It default value will be localhost.

Related Issue(s)

Fixes #

@tinesoft tinesoft requested a review from a team as a code owner November 23, 2024 17:03
Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2024 7:49am

tinesoft added a commit to tinesoft/nxrocks that referenced this pull request Nov 24, 2024
tinesoft added a commit to tinesoft/nxrocks that referenced this pull request Nov 27, 2024
… starting the local registry

Until nrwl/nx#29050 is merged and released
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants