feat(testing): improve local registry script… #29050
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… output
Current Behavior
The
startLocalRegistry()
always assumed that the local registry was started onlocalhost
, which is not necessary the case, if for example user has set thelistenAddress
option in the underlyingverdaccio executor
or via theverdaccio config file
nx/packages/js/src/executors/verdaccio/verdaccio.impl.ts
Line 130 in 128778e
As a result the
startLocalregistry()
, will never return as, it is waiting forever to detect the local registry URL in the process output:nx/packages/js/src/plugins/jest/start-local-registry.ts
Line 40 in 128778e
Expected Behavior
Allow customizing the
listenAddress
when starting the local registry, via an additional option that can be provided when calling the method. It default value will belocalhost
.Related Issue(s)
Fixes #