chore(repo): add conformance rule for our package.json files #29078
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "@jest/reporters": "^29.4.1", | ||
| "@jest/test-result": "^29.4.1", | ||
| "@jest/types": "^29.4.1", | ||
| "@jest/reporters": "29.7.0", |
There was a problem hiding this comment.
Our jest packages weren't aligned for some reason
| @@ -60,5 +60,8 @@ | |||
| }, | |||
| "nx-migrations": { | |||
| "migrations": "./migrations.json" | |||
| }, | |||
| "publishConfig": { | |||
There was a problem hiding this comment.
Found by the new rule!
There was a problem hiding this comment.
I thought we needed this for provenance... how does rspack have provenance without this?
There was a problem hiding this comment.
It's not for provenance, it's needed because the default access for new scoped package is restricted and so the first time we publish a new package we need this explicit config. Technically after that point we no longer need it anymore, but it doesn't do any harm, just makes its state explicit, and so having this be a rule for all package.json files means we won't run into any issues when new packages are added in future.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b9be66d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
| @@ -1,7 +1,8 @@ | |||
| /* eslint-disable */ | |||
| export default { | |||
| displayName: 'workspace-plugin', | |||
| preset: '../../jest.preset.js', | |||
| // TODO: For some reason our patched jest resolve cannot work with @nx/powerpack-conformance | |||
There was a problem hiding this comment.
Needs some time spent on it, there's a lot of custom complexity there, the default resolver works fine...
There was a problem hiding this comment.
Looks like this is blocking the PR after all because the existing code in this library needs the custom resolver, damn
No description provided.