improve polygon coordinate handling #506
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhkennedy
reviewed
Apr 1, 2024
earthaccess/search.py
Outdated
| def polygon( | ||
| self, | ||
| coordinates: Union[ | ||
| shapely.geometry.polygon.Polygon, str, bytes, List[Tuple[str, str]] |
There was a problem hiding this comment.
Suggested change
| shapely.geometry.polygon.Polygon, str, bytes, List[Tuple[str, str]] | |
| shapely.geometry.base.BaseGeometry, str, bytes, List[Tuple[str, str]] |
I think since the rest of the implementation works of off the BaseGeometry, we could just use that here as well. We probably want to add some tests with different geometries and especially a clockwise vs couterclockwise ones
There was a problem hiding this comment.
Done (583de40). Will think about/work on tests later this week/next week.
chuckwondo
reviewed
Apr 8, 2024
|
|
||
| if isinstance(coordinates, shapely.geometry.base.BaseGeometry): | ||
| geom = coordinates | ||
| elif isinstance(coordinates, list): |
There was a problem hiding this comment.
Using list is too restrictive. This should likely be Sequence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed/explained/requested in #504:
shapelygeometry, WKT strings, and WKB geometriesshapely>=2.0.0as a dependency topyproject.toml📚 Documentation preview 📚: https://earthaccess--506.org.readthedocs.build/en/506/