Create dest dir for direct S3 access before download

[chuckwondo]

I didn't add a unit or integration test for this, as I wasn't sure about how best to test this, so I'm open to suggestion.

Fixes #562

---

📚 Documentation preview 📚: https://earthaccess--570.org.readthedocs.build/en/570/

[mfisher87]

Looks good so far! For testing, I'm thinking we could extract a download_s3_granules(path: Path, data_links: list[str]) -> list[Path] function and give it the input required to reproduce the bug in a test?

Really we should be testing that any time we write granules we will correctly create an output directory, but if nobody has time to do that refactoring right now, the above approach would at least add coverage to this change 🤷 No strong feelings.

[mfisher87]

Indentation is off by 2 spaces with the items above

[chuckwondo]

Oops! I'll sort that out with my other PR, where I've reformatted the section. I didn't want to create much of a merge conflict for myself here.

[chuckwondo]

Looks good so far! For testing, I'm thinking we could extract a download_s3_granules(path: Path, data_links: list[str]) -> list[Path] function and give it the input required to reproduce the bug in a test?

Really we should be testing that any time we write granules we will correctly create an output directory, but if nobody has time to do that refactoring right now, the above approach would at least add coverage to this change 🤷 No strong feelings.

I think the problem with testing this is that we cannot guarantee that tests will run in an AWS environment that's "in region." If that's not possible, then manually setting earthaccess.__store__.in_region = True doesn't help us because if the test is not actually running "in region", attempting a direct S3 download simply results in PermissionError: Access Denied.

[mfisher87]

Hm. I don't have any great ideas here. @betolink ?

I'd be fine with merging without adding a test and recording a bug to add a test later. Better to get the fix in the hands of users sooner IMO. We can flail around figuring out unit tests on our time 🤣