-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(action): site + example publish #410
base: master
Are you sure you want to change the base?
Conversation
6d088f3
to
559cd92
Compare
Okay. The approach with pages won't work (because you can only define one domain for deploy). I'll rework this pr a bit and the we only need to add secrets containing the sensitive data. |
763efa2
to
313581c
Compare
313581c
to
b2aeddb
Compare
08a2513
to
d0fc2ba
Compare
d0fc2ba
to
f96a6f4
Compare
9c45e52
to
e33d83c
Compare
I might have to still add some code until the next release, so the example unpacking doesn't break. Because I changed the unpack logic to not strip the first path segment. so with the change, the RC version would strip a path segment too much, cause the archives don't include the directory anymore. Before: super directory I will add that extra logic sometime next week (sorry that this is going forward so slowly), and remove it a while after the next release. After that, this PR should be ready. It might just need some provider specific tweaks. Depends on how the files are saved on the web server. I could also try changing the compression strategy back, but I think that might be harder, because I currently use git to only compress versioned files, and also don't include the directory itself. I think I'm repreating myself, I should go do something different... |
This is still very much WIP, and completely untested.
I'll try working more on this, sometime next week.