Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action): site + example publish #410

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nobkd
Copy link
Collaborator

@nobkd nobkd commented Nov 17, 2024

This is still very much WIP, and completely untested.
I'll try working more on this, sometime next week.

@nobkd nobkd force-pushed the feat-action/web-publish branch 5 times, most recently from 6d088f3 to 559cd92 Compare November 21, 2024 18:09
@nobkd
Copy link
Collaborator Author

nobkd commented Nov 27, 2024

Okay. The approach with pages won't work (because you can only define one domain for deploy).
But we can probably just compress our generated files push them over to the server via key based ssh and gh secrets and then unpack the files on the other side. (of course you could leave out the compression step, but it's probably much less space and time needed for transfer then.)

I'll rework this pr a bit and the we only need to add secrets containing the sensitive data.

@nobkd nobkd force-pushed the feat-action/web-publish branch 3 times, most recently from 763efa2 to 313581c Compare November 29, 2024 18:17
@nobkd nobkd force-pushed the feat-action/web-publish branch 5 times, most recently from 08a2513 to d0fc2ba Compare November 29, 2024 23:53
@nobkd
Copy link
Collaborator Author

nobkd commented Dec 1, 2024

I might have to still add some code until the next release, so the example unpacking doesn't break.

Because I changed the unpack logic to not strip the first path segment. so with the change, the RC version would strip a path segment too much, cause the archives don't include the directory anymore.

Before: super directory simple-blog containing all the files is archived
With this PR: only contents of simple-blog, not the directory itself is archived

I will add that extra logic sometime next week (sorry that this is going forward so slowly), and remove it a while after the next release.

After that, this PR should be ready. It might just need some provider specific tweaks. Depends on how the files are saved on the web server.

I could also try changing the compression strategy back, but I think that might be harder, because I currently use git to only compress versioned files, and also don't include the directory itself.

I think I'm repreating myself, I should go do something different...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants