[Caleb Chan] iP #191

calebcjl · 2023-01-31T10:51:05Z

No description provided.

ngyida

Mostly clean code that is easy to follow. Minor amendments to naming and cosmetics requested.

src/main/java/Task.java

src/main/java/Nano.java

src/main/java/Task.java

heejet

Overall good job following the java coding standards. Variables names are in camelCase, constant names are in uppercase with underscore to separate the words. Method names are verbs.

src/main/java/Nano.java

src/main/java/Task.java

src/main/java/Nano.java

New classes are: 1. Deadline - Task with due date 2. Event - Task with start and end date 3. Todo - regular Task

Exceptions added: 1. DukeCommandExeception: user entered invalid command 2. DukeInputFormatException: user input has wrong format

siyuancheng178

Great! Very concise and readable code. No coding violation found

Add feature to find and list tasks containing a keyword

calebcjl added 6 commits January 19, 2023 18:57

Rename chatbot to Nano and add greeting and exit message

c5b2f77

Add echo user input feature and exit condition

8cb1426

Change echo feature to store user input in a list

5690fae

Add task class and feature to mark tasks

daafab5

Tweak to coding standard and display number of completed tasks in list

d9c167a

Refactor code to improve quality

b3d9e39

ngyida reviewed Feb 2, 2023

View reviewed changes

heejet reviewed Feb 2, 2023

View reviewed changes

calebcjl added 8 commits February 4, 2023 15:53

Improve code based on peer reviews

57b1f39

Add new classes to represent different types of Task

a8bd85d

New classes are: 1. Deadline - Task with due date 2. Event - Task with start and end date 3. Todo - regular Task

Add exceptions to detect incorrect input

4c0bc00

Exceptions added: 1. DukeCommandExeception: user entered invalid command 2. DukeInputFormatException: user input has wrong format

Organise classes into packages

0dd2ccb

Add /help command to list out all possible commands

0072420

Merge branch 'branch-A-Package'

5ff0543

Merge branch 'branch-Level-5'

3e3cce1

Create new package for Nano exceptions

2db7774

siyuancheng178 reviewed Feb 13, 2023

View reviewed changes

calebcjl and others added 12 commits February 16, 2023 11:58

Use ArrayList to store tasks instead of fixed array

d7f2d9e

Add delete feature

8d667e9

Add feature to save and retrieve user task list data

8cf3a5d

Merge branch 'branch-Level-6'

d4c1c33

Merge branch 'branch-Level-7'

da6e71f

Refactor code to include new classes and packages for more OOP

b3afe13

Add feature to find and list tasks containing a keyword

f44d88a

Merge pull request #1 from calebcjl/branch-Level-9

2a52cb3

Add feature to find and list tasks containing a keyword

Merge branch 'master' of https://github.com/calebcjl/ip

4939e2c

Add JavaDoc comments to code

d7094b0

Add user guide for Nano

f9280aa

Update the correct README for user guide

0d5f844

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Caleb Chan] iP #191

[Caleb Chan] iP #191

calebcjl commented Jan 31, 2023

ngyida left a comment

heejet left a comment

siyuancheng178 left a comment

[Caleb Chan] iP #191

Are you sure you want to change the base?

[Caleb Chan] iP #191

Conversation

calebcjl commented Jan 31, 2023

ngyida left a comment

Choose a reason for hiding this comment

heejet left a comment

Choose a reason for hiding this comment

siyuancheng178 left a comment

Choose a reason for hiding this comment