[CHEN ZIHAN] ip #198

ZIZI-czh · 2023-01-31T16:24:35Z

this up to level 2

stevenantya

Overall good job on the pull request! Only few minor consistency and coding standards issues.

stevenantya · 2023-02-02T07:46:26Z

src/main/java/Duke.java

+    }
+
+
+


remove the unnecessary blank spaces, follow one uniform spacing

stevenantya · 2023-02-02T07:47:06Z

src/main/java/Duke.java

+
+
+
+    public static void add() {


Coding Standard violation: Ambiguity of function.

Can change the name of the function to explain more. e.g. addTodo()

stevenantya · 2023-02-02T07:50:19Z

src/main/java/Duke.java

+
+    public static void add() {
+        boolean isByeEntered = true;
+        String outputs;


Coding Standard Violation: Plural form is reserved for collections of objects.

Suggested change

String outputs;

String output

stevenantya · 2023-02-02T07:54:17Z

src/main/java/Duke.java

+    public static void add() {
+        boolean isByeEntered = true;
+        String outputs;
+        String[] storeList;


Coding Standard Violation: Array should be plural

Suggested change

String[] storeList;

String[] storeLists;

stevenantya · 2023-02-02T07:57:44Z

src/main/java/Duke.java

                System.out.println("Bye. Hope to see you again soon!");
                return;
-            }else{
-            System.out.println(outputs);
+            } else if(outputs.equals("list")){


Coding Standard Violation: Give space before and after statement

Suggested change

} else if(outputs.equals("list")){

} else if(outputs.equals("list")) {

same goes for line 30, 35

kairuler

Overall, I like how your code is quite clean and you adhered to coding standards most of the time! I noticed some variable names and spacing that you may have unintentionally overlooked but they are just minor errors. Good job!

kairuler · 2023-02-02T07:45:23Z

src/main/java/Duke.java


-        boolean isByeEntered = true;
-        String outputs;
+    public static final int MAX_INT = 100;


Nice! I like your usage of constants (instead of magic numbers) and I like how they are typed (all uppercase, underscore to separate words).

kairuler · 2023-02-02T07:55:18Z

src/main/java/Duke.java

+
+
+    public static void add() {
+        boolean isByeEntered = true;


Could isByeEntered be named to sound more like a boolean variable? It is a bit confusing what isByeEntered does just based off its name 😁 .

kairuler · 2023-02-02T07:59:28Z

src/main/java/Duke.java

+                    if(list!=null) {
+                        System.out.println(a + ". " + list);
+                        a++;
+                    }else{


Spacing is sometimes inconsistent (maybe by accident?). Here, }else{ has no spaces between the braces but elsewhere, there are spaces. I noticed this a few times in the above code too. Be sure to double check!

kairuler · 2023-02-02T08:03:22Z

src/main/java/Duke.java

+    public static void add() {
+        boolean isByeEntered = true;
+        String outputs;
+        String[] storeList;


I like how your array specifier is attached to the type and not the variable 👍 nice

kairuler · 2023-02-02T08:31:38Z

src/main/java/Duke.java

+        String[] storeList;
+        storeList = new String[MAX_INT];
+        int i = 0;
+        int a = 1;


I wasn't sure on what a did until I read the code fully... I think changing the variable name a could make it more understandable for readers!

siyuancheng178 · 2023-02-13T09:29:34Z

src/main/java/Duke.java

+            case "Bye":
+                System.out.println("Bye. Hope to see you again soon!");
+                isByeEnter = true;
+                break;


Please separate into different methods to handle different commands, such as displayAllTasks(), UnmarkTask() etc.

update

ZIZI-czh added 4 commits January 31, 2023 21:33

This is greed for level0

1f84246

edit duke

a1b47d9

This is level 1 code

150d2b1

This is level 2

9fb9073

stevenantya reviewed Feb 2, 2023

View reviewed changes

kairuler reviewed Feb 2, 2023

View reviewed changes

Level 3: Mark as Done

1948f11

siyuancheng178 reviewed Feb 13, 2023

View reviewed changes

ZIZI-czh added 22 commits February 14, 2023 17:45

Level 4: ToDos, Events, Deadlines

20513b3

A-TextUiTesting: Automated Text UI Testing

2f37e5d

A-CodeQuality: Improve Code Quality

aad1876

This is branch-Level-5 which includes Level 5: Handle Errors

52c2484

This is branch-level-5 which includes Level 5: Handle Errors

2531402

update brach for package

46b06d9

create package and assign each file to the respective packages

bc3b345

This is incomplete delete

feac7eb

Solve merge conflict

96306a3

This is level 6

31edec0

Change in branch-level-6

3d14bd2

Level 6 and part of level 7

5673757

no message

cd4ec76

This is level 7

07841ce

This is level 7

3bce789

solve conflict

18ced02

clean space

a8b8903

A-moreOOP

8260134

solve for conflict

c6c4e31

Implement the function of find

c44b7a0

level-9 formatting

da48b0a

This is JavaDoc

31518e0

ZIZI-czh and others added 7 commits March 5, 2023 23:58

changes

144ebda

Update README

aca6055

Update README

3d4ec2e

update

91ab442

update

2ca723e

Merge branch 'master' into branch-Level-9

9717c16

Merge pull request #1 from ZIZI-czh/branch-Level-9

330455f

update

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CHEN ZIHAN] ip #198

[CHEN ZIHAN] ip #198

ZIZI-czh commented Jan 31, 2023 •

edited

Loading

stevenantya left a comment

stevenantya Feb 2, 2023

stevenantya Feb 2, 2023

stevenantya Feb 2, 2023

stevenantya Feb 2, 2023

stevenantya Feb 2, 2023

stevenantya Feb 2, 2023

kairuler left a comment

kairuler Feb 2, 2023

kairuler Feb 2, 2023

kairuler Feb 2, 2023

kairuler Feb 2, 2023

kairuler Feb 2, 2023

siyuancheng178 Feb 13, 2023

	} else if(outputs.equals("list")){
	} else if(outputs.equals("list")) {

[CHEN ZIHAN] ip #198

Are you sure you want to change the base?

[CHEN ZIHAN] ip #198

Conversation

ZIZI-czh commented Jan 31, 2023 • edited Loading

stevenantya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kairuler left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZIZI-czh commented Jan 31, 2023 •

edited

Loading