[SaiChaitanya13] ip #203

SaiChaitanya13 · 2023-01-31T19:38:01Z

No description provided.

choongzhanhong

Looks good!
Mainly, with regards to code style, I have pointed out some areas regarding spacing and comments that you may find could be addressed.

choongzhanhong · 2023-02-01T04:35:47Z

src/main/java/Buddy.java

+                currentPosition++;
+            }*/
+
+            else{ //todo or deadline or event --> put together so don't have to repeat the same code thrice


I like the fact that you split the if/else blocks quite meaningfully, along with descriptive comments.

choongzhanhong · 2023-02-01T04:42:17Z

src/main/java/Buddy.java

+                    // filter the description and date
+                    String taskWithDate = taskBeingAdded.description;
+                    int indexOfSlash = taskWithDate.indexOf('/');
+                    String taskDescription = taskWithDate.substring(0, (indexOfSlash - 1));   // substring goes to the one before the second index!!!!


Perhaps it might be good to indent the multiple line comments to be aligned with the block?

choongzhanhong · 2023-02-01T04:45:00Z

src/main/java/Buddy.java

+        String greeting = "Hello there! I'm Buddy\n"
+                + "How may I assist you?";
+        String exitMessage = "Hope I was of help to you! Have a great day and see you again, Buddy :)";
+        String divider = "________________________________________________________________________________";


I like that you extracted these as properties. If they're constants, could you give the proper modifiers and variable name as well?

choongzhanhong · 2023-02-01T04:47:18Z

src/main/java/Buddy.java

+
+
+
+        System.out.println(divider);


Could there be fewer new lines here?

choongzhanhong · 2023-02-01T04:48:30Z

src/main/java/Task.java

+    @Override
+    public String toString() {                      // overrides --> print task prints this!


Could the comment be indented/spaced closer to the block it's referring to?

choongzhanhong · 2023-02-01T05:00:30Z

src/main/java/Buddy.java

+        while (! command.equals("bye")){
+            int index = 1;
+            if (command.equals("list")){
+                for (int i = 0; i < currentPosition; i++){ // while not null


Perhaps a space could be added before the opening braces, like so: else {?
I believe there are multiple occurrences below as well.

ysl-28

Overall, the code is generally readable. However, the use of magic numbers could be reduced.

ysl-28 · 2023-02-01T05:20:09Z

src/main/java/Buddy.java

+            }
+
+            else if (command.startsWith("mark")){  // .startsWith(" ")
+                int taskNumber = Integer.parseInt(command.substring(5));


Would it be clearer to use a constant instead of a magic number?

ysl-28 · 2023-02-01T08:18:25Z

src/main/java/Buddy.java

+            /*else { // adding tasks
+                listOfThings[currentPosition] = new Task(command); // have to write in
+                //Task t = new Task(command);
+                System.out.println(divider);
+                System.out.println("added: " + command);
+                System.out.println(divider);
+                currentPosition++;
+            }*/


Perhaps it would be more readable to remove chunks of commented code?

ysl-28 · 2023-02-01T08:26:02Z

src/main/java/Buddy.java

+                System.out.println(divider);
+            }
+
+            else if (command.startsWith("unmark")){


Perhaps it would be clearer to follow the Java coding standard for writing if-else statements?

if (condition) { statements; } else if (condition) { statements; } else { statements; }

ysl-28 · 2023-02-01T08:28:20Z

src/main/java/Buddy.java

+
+                else if (command.startsWith("deadline")){
+                    Task taskBeingAdded = new Task(command.substring(9)); // task + date + slash (Description)
+                    // filter the description and date


I like the use of comments to explain the code when needed.

ysl-28 · 2023-02-01T08:37:48Z

src/main/java/Buddy.java

+                    Todo todoBeingAdded = new Todo(command.substring(5));
+                    listOfThings[currentPosition] = todoBeingAdded;


I like that the variable names are clear and follow the coding standard.

Geeeetyx

Overall good work, but you can tidy up the code to make it look like nicer.

Geeeetyx · 2023-02-03T07:25:30Z

src/main/java/Buddy.java

+            else if (command.startsWith("mark")){  // .startsWith(" ")
+                int taskNumber = Integer.parseInt(command.substring(5));
+                // have to parse
+                Task currentTask = listOfThings[taskNumber - 1];


Good that variable names follow camel case

Geeeetyx · 2023-02-03T07:27:33Z

src/main/java/Buddy.java

+                System.out.println(divider);
+            }
+
+            else if (command.startsWith("unmark")){


Might be better to use switch case statements here

Geeeetyx · 2023-02-03T07:33:53Z

src/main/java/Buddy.java

+                }
+            }
+
+            else if (command.startsWith("mark")){  // .startsWith(" ")


It might be good to refactor these else if statements to be methods

Geeeetyx · 2023-02-03T07:34:42Z

src/main/java/Buddy.java

+                else if (command.startsWith("deadline")){
+                    Task taskBeingAdded = new Task(command.substring(9)); // task + date + slash (Description)
+                    // filter the description and date
+                    String taskWithDate = taskBeingAdded.description;


Clear variable names that are easy to understand

Geeeetyx · 2023-02-03T07:36:00Z

src/main/java/Buddy.java

+        System.out.println(greeting);
+        System.out.println(divider);
+
+        Task[] listOfThings = new Task[100];  // why cannot private static?


Perhaps remove comments that are not explaining the code

maanyos

please work on the object orientedness in the code.
try to create command class (and subclasses) to refactor logic by different commands. refer to addressbook3 if necessary

maanyos · 2023-02-18T09:14:34Z

src/main/java/Buddy.java

+
+    static final int TOTAL_TASKS = 100;
+
+    public static void main(String[] args) {


too much happening in main, try to refactor to improve readibility and abstraction

maanyos · 2023-02-18T09:15:29Z

src/main/java/Buddy.java

+        Task[] listOfThings = new Task[TOTAL_TASKS];  // why cannot private static?
+        int currentPosition = 0;            // why cannot private static?


don't leave comments for yourself in the code

maanyos · 2023-02-18T09:20:31Z

src/main/java/Task.java

+        return (isDone ? "X" : " "); // mark done task with X
+    }
+
+    public boolean isDone() {  // do we need this


use action naming for method

SaiChaitanya13 pr

SaiChaitanya13 added 6 commits January 28, 2023 22:22

Added Increment - Level 0

cbe03ba

Added Increment - Level 1

f2d0bfe

Added Increment - Level 2

e5f9282

Added Increment - Level 3

c0efa6e

Coding Standards --> Used camelCase throughout

eae4525

Added Increment - Level 4

7435c1a

choongzhanhong reviewed Feb 1, 2023

View reviewed changes

ysl-28 reviewed Feb 1, 2023

View reviewed changes

Geeeetyx reviewed Feb 3, 2023

View reviewed changes

SaiChaitanya13 added 8 commits February 9, 2023 23:23

Cleaned up code + Added increment - Code Quality

8c9d925

Cleaned up code + Added increment - Code Quality

4a3350e

Improved code quality

8bf9626

Added Level 5 for two exceptions + reformatted code

8e63c8d

Added exceptions for Level 5

63a70ee

Merge branch 'branch-Level-5'

7d9c743

add delete command

cc2f69d

add delete command

1f72f15

maanyos reviewed Feb 18, 2023

View reviewed changes

SaiChaitanya13 added 12 commits February 19, 2023 23:24

Changed to array list + Added Level 6

6d07cfd

refactored code

8c7e7a7

added Storage

a969961

resolve merge conflicts

f8c9289

add delete command

5fe1586

add delete command

9c94db0

Changed to array list + Added Level 6

cca8512

refactored code

8d246b7

Merge branch 'branch-Level-6'

a9ef0bd

delete branch 7 to make it easier

678f733

Done till Level 6

154b006

Testing

a6e5092

SaiChaitanya13 and others added 30 commits March 3, 2023 00:44

Added Task List Class which works!!

999cf72

Added the different Task Command Classes

8a086b7

Added ALL Command classes - Task and Action

df06edd

Added Parser Class and works

511e48c

Added Messages Class

4c43b1e

Added Help Command and Help Message

8f0a3e8

Added Greeting

5c3cb49

Add Date Time Formatter for Deadline

5bebd19

changing just to merge

de0616c

Merge branch 'branch-Level-8'

1dd986b

Added exceptions to code

bb101ad

merge conflicts resolved

7b4656e

Added Testing

e45aba2

All works, adding UI

8ca8fd8

Added MoreOOP everything works

3ffea71

added to main, debugging issues

2675b55

file works WITHOUT directory

39a3bfb

imported packages without * so better coding standard

856052c

LETS GO Storage Path changed with directory AND IT WORKS!

e444e1b

minor reformatting of code

acc7aea

Made minor documentation

beb0c51

Added ALL Documentation in the right format

8cc346b

Merge branch 'branch-A-JavaDoc'

a3f035e

Reformatted code and added in some additional checks

c2fc057

Fixed many bugs

9aff198

Added User Guide

15e388b

FINAL CHANGES FINALISED BUDDY YAY

cb8a6f0

slight change

0a0118e

small change for merge

57d9fcb

Merge pull request #1 from SaiChaitanya13/mergepr

3be8a94

SaiChaitanya13 pr

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SaiChaitanya13] ip #203

[SaiChaitanya13] ip #203

SaiChaitanya13 commented Jan 31, 2023

choongzhanhong left a comment

choongzhanhong Feb 1, 2023

choongzhanhong Feb 1, 2023

choongzhanhong Feb 1, 2023

choongzhanhong Feb 1, 2023

choongzhanhong Feb 1, 2023

choongzhanhong Feb 1, 2023

ysl-28 left a comment

ysl-28 Feb 1, 2023

ysl-28 Feb 1, 2023

ysl-28 Feb 1, 2023

ysl-28 Feb 1, 2023

ysl-28 Feb 1, 2023

Geeeetyx left a comment

Geeeetyx Feb 3, 2023

Geeeetyx Feb 3, 2023

Geeeetyx Feb 3, 2023

Geeeetyx Feb 3, 2023

Geeeetyx Feb 3, 2023

maanyos left a comment

maanyos Feb 18, 2023

maanyos Feb 18, 2023

maanyos Feb 18, 2023

		@Override
		public String toString() { // overrides --> print task prints this!

		Todo todoBeingAdded = new Todo(command.substring(5));
		listOfThings[currentPosition] = todoBeingAdded;


		static final int TOTAL_TASKS = 100;

		public static void main(String[] args) {

		Task[] listOfThings = new Task[TOTAL_TASKS]; // why cannot private static?
		int currentPosition = 0; // why cannot private static?

[SaiChaitanya13] ip #203

Are you sure you want to change the base?

[SaiChaitanya13] ip #203

Conversation

SaiChaitanya13 commented Jan 31, 2023

choongzhanhong left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ysl-28 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Geeeetyx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maanyos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment