Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sebastian Soewanto] iP #205

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions src/main/java/Duke.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,39 @@ public static void main(String[] args) {
+ "| |_| | |_| | < __/\n"
+ "|____/ \\__,_|_|\\_\\___|\n";

String line = "_________________________________\n";
String line = "____________________________________________________\n";
Copy link

@DavidVin357 DavidVin357 Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it is a constant, so maybe consider using static final LINE_DIVIDER (or some other similar name)?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming can be changed to avoid confusion down the code block, could change to -> e.g. 'static final String margin' (since its a repeating string pattern to be printed out)

System.out.println("Hello from\n" + logo);
System.out.print(line + "Hello! I'm Duke\n" + "What can I do for you?\n" + line);
String[] list = new String[100];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you use this list to store the different tasks, so maybe it's better to name it as tasks? :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming of ' String[ ] list ' is quite vague, maybe if possible to provide a more useful name for readability? e.g. ' String [ ] taskList '

boolean[] isDone = new boolean[100];
String toFill;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think naming it checkerContent or some other noun may better represent the meaning of the variable (verbs are more suitable to be used for the methods)

int listCount = 0;
Copy link

@DavidVin357 DavidVin357 Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like tasksCount can tell better on what you are counting here?

while(true) {
Scanner userInput = new Scanner(System.in);
String input = userInput.nextLine();
if (input.equals("bye")) {
System.out.print(line + "Bye. Hope to see you again soon!\n" + line);
break;
} else if(input.equals("list")) {
} else if (input.startsWith("mark")) {
int mark = Integer.parseInt(input.substring(5));
isDone[mark - 1] = true;
System.out.println(line + "Nice! I've marked this task as done:\n" + " [X] " + list[mark - 1]);
System.out.print(line);
} else if (input.startsWith("unmark")) {
int unmark = Integer.parseInt(input.substring(7));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming of ' unmark' is a bit confusing, maybe switch to ' taskToUnmark '?

isDone[unmark - 1] = false;
System.out.println(line + "OK, I've marked this task as not done yet:\n" + " [ ] "+ list[unmark - 1]);
System.out.print(line);
} else if(input.equals("list")) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good indentation and presenting the conditional statements, which helps the code's readability.

System.out.print(line + "Here are the tasks in your list:\n");
for (int i = 0; i < listCount; i++) {
System.out.println(i + 1 + ". " + list[i]);
if (isDone[i]) {
toFill = "X";
}
else {
toFill = " ";
}
System.out.println(i + 1 + ". [" + toFill + "] " + list[i]);
Copy link

@DavidVin357 DavidVin357 Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracting i+1 to another line as i++ may make the code a little bit more clean)

}
System.out.print(line);
} else {
Expand Down