[Lyu Xingyu] iP #206

Zemdalk · 2023-02-01T06:38:05Z

No description provided.

…user and exits.

lihka1202 · 2023-02-03T02:49:30Z

src/main/java/Duke.java

+            if(line.equals("bye")){
+                // quit
+                System.out.println(exitPrompt);
+                break;
+            }else{


Perhaps you can leave a space after the conditional clause and opening brace

lihka1202 · 2023-02-03T02:51:05Z

src/main/java/Duke.java

+                    try {                        
+                        index = Integer.parseInt(line.substring(funcIdx+1, line.length())) - 1;
+                    } catch (Exception e) {
+                        index = -1;
+                    }


I like how you have added error handling

New implementation I've noticed. I have not seen this before. Maybe something that I should google up. Well done~

lihka1202 · 2023-02-03T02:55:29Z

src/main/java/Duke.java

+                if(funcIdx == -1){
+                    funcIdx = line.length();
+                }
+                String func = line.substring(0, funcIdx);


perhaps you could give this variable a better name, as it is stored as a String but is named func

I agree with @lihka1202 . I'd suggest to give a variable name like commandIndex or inputIndex as it it a bit more clear for readers to understand what you are referring to.

Thank you for your good suggestions! I have made corrections.

lihka1202 · 2023-02-03T02:57:06Z

src/main/java/Duke.java

+                    }
+                    todoList.markItem(index, false);
+                }else if(func.equals("todo")){
+                    Todo todo = Todo.toTodo(instruction);


Perhaps you could name object todo better, as it has the same name as the class and it might get confusing!

lihka1202 · 2023-02-03T02:59:14Z

src/main/java/Duke.java

+                    // mark work as done
+                    int index;
+                    try {                        
+                        index = Integer.parseInt(line.substring(funcIdx+1, line.length())) - 1;


Could you abstract this out to maintain SLAP

Agreed. Thank you for your suggestion!

TopGun2001 · 2023-02-03T03:49:05Z

src/main/java/Duke.java

+                if(funcIdx == -1){
+                    funcIdx = line.length();
+                }
+                String func = line.substring(0, funcIdx);


I agree with @lihka1202 . I'd suggest to give a variable name like commandIndex or inputIndex as it it a bit more clear for readers to understand what you are referring to.

TopGun2001 · 2023-02-03T03:52:27Z

src/main/java/Duke.java

+                    try {                        
+                        index = Integer.parseInt(line.substring(funcIdx+1, line.length())) - 1;
+                    } catch (Exception e) {
+                        index = -1;
+                    }


New implementation I've noticed. I have not seen this before. Maybe something that I should google up. Well done~

TopGun2001 · 2023-02-03T03:54:49Z

src/main/java/Event.java

+        int contentIdx = instruction.indexOf("/from");
+        int fromIdx = instruction.indexOf("/to");


Perhaps u could use Index instead of Idx

0nandon · 2023-02-03T14:14:15Z

src/main/java/Duke.java

+                    if(todo == null){
+                        printError("Wrong todo format");
+                        continue;
+                    }
+                    todoList.addItem(todo);
+                }else if(func.equals("deadline")){
+                    Deadline deadline = Deadline.toDeadline(instruction);
+                    if(deadline == null){
+                        printError("Wrong deadline format");
+                        continue;
+                    }
+                    todoList.addItem(deadline);
+                }else if(func.equals("event")){
+                    Event event = Event.toEvent(instruction);
+                    if(event == null){
+                        printError("Wrong event format");
+                        continue;
+                    }
+                    todoList.addItem(Event.toEvent(instruction));


'switch' statement would be better since there are many cases you want to separate.

0nandon

Function is better to be in verb form.

0nandon · 2023-02-03T14:17:22Z

src/main/java/Deadline.java

+        return new Deadline(deadlineContent, deadlineBy);
+    }
+
+    public Deadline(String description, String by) {


Suggested change

public Deadline(String description, String by) {

public getDeadline(String description, String by) {

0nandon

It is better to avoid deep nesting as possible as you can.

0nandon · 2023-02-03T14:25:30Z

src/main/java/Duke.java

+                    if(todo == null){
+                        printError("Wrong todo format");
+                        continue;
+                    }
+                    todoList.addItem(todo);
+                }else if(func.equals("deadline")){
+                    Deadline deadline = Deadline.toDeadline(instruction);
+                    if(deadline == null){
+                        printError("Wrong deadline format");
+                        continue;
+                    }
+                    todoList.addItem(deadline);
+                }else if(func.equals("event")){
+                    Event event = Event.toEvent(instruction);
+                    if(event == null){
+                        printError("Wrong event format");
+                        continue;
+                    }
+                    todoList.addItem(Event.toEvent(instruction));


There is deep nesting in if-else statement while every if statements inside are conducting similar calculation. There would be other way to better construct this code like declaring special function for those calculation.

0nandon · 2023-02-03T14:38:17Z

src/main/java/TodoList.java

+            System.out.println(SPLITTER);
+            System.out.println("    OK, I've marked this task as not done yet:");
                System.out.print("      [ ] ");
            }
            System.out.println(tasks[num].getDescription());
            System.out.println(SPLITTER);
            System.out.println();


So many printings, I think in if-else statement. How about just making additional function for those printing stacks?

Level-8: Dates and Times

Level-9: Find

Add header comments to all non-private classes/methods, and non-trivial private methods.

Zemdalk added 9 commits January 17, 2023 00:52

Level-0: initial skeletal version of the Duke that simply greets the …

9ab46e1

…user and exits.

Level-1: Greet, Echo, Exit

dc3f098

Level-2: Add, List

97423b2

Level-3: Mark as Done

63a191e

A-CodingStandard

61029ce

Level-4: ToDos, Events, Deadlines

06ae0dc

A-TextUiTesting

1fbda4e

A-TextUiTesting

203fea6

A-CodeQuality: adjust indent and delete some useless comments

5f08aa5

lihka1202 reviewed Feb 3, 2023

View reviewed changes

TopGun2001 reviewed Feb 3, 2023

View reviewed changes

0nandon reviewed Feb 3, 2023

View reviewed changes

Zemdalk and others added 15 commits February 8, 2023 18:51

code: follow some PRs' suggestions

0df796d

code: follow some PRs' suggestions

3199eec

Level-5: add exception handlers

64bf8a0

Level-5: remove leading and trailing zeros in exception handling

5db98b6

Merge branch 'branch-Level-5'

34bb510

A-Packages

c7547ef

Level-6: Delete

8e92840

Level-7: Save

6d527d3

Level-7: Save

12d4b97

A-Jar

a6c842d

refactor: modify code according to TA's suggetions

52047bb

file: add in

30ba487

A-MoreOOP

fc51ce6

Level-8: Dates and Times

acbca13

Merge pull request #4 from Zemdalk/branch-Level-8

5b66aaa

Level-8: Dates and Times

Zemdalk and others added 6 commits February 24, 2023 02:58

Level-9: Find

bc9d59f

Merge pull request #5 from Zemdalk/branch-Level-9

6e9ec36

Level-9: Find

A-JavaDoc

a7fded6

Add header comments to all non-private classes/methods, and non-trivial private methods.

A-UserGuide: add a user guide

7fcb84b

A-UserGuide: add a user guide

a2a863a

A-UserGuide: add a user guide

b1f0938

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lyu Xingyu] iP #206

[Lyu Xingyu] iP #206

Zemdalk commented Feb 1, 2023

lihka1202 Feb 3, 2023

lihka1202 Feb 3, 2023

TopGun2001 Feb 3, 2023

lihka1202 Feb 3, 2023

TopGun2001 Feb 3, 2023

Zemdalk Feb 9, 2023

lihka1202 Feb 3, 2023

lihka1202 Feb 3, 2023

Zemdalk Feb 9, 2023

TopGun2001 Feb 3, 2023

TopGun2001 Feb 3, 2023

TopGun2001 Feb 3, 2023

0nandon Feb 3, 2023

0nandon left a comment

0nandon Feb 3, 2023

0nandon left a comment

0nandon Feb 3, 2023

0nandon Feb 3, 2023 •

edited

Loading

		int contentIdx = instruction.indexOf("/from");
		int fromIdx = instruction.indexOf("/to");

	public Deadline(String description, String by) {
	public getDeadline(String description, String by) {

[Lyu Xingyu] iP #206

Are you sure you want to change the base?

[Lyu Xingyu] iP #206

Conversation

Zemdalk commented Feb 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0nandon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0nandon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0nandon Feb 3, 2023 • edited Loading

Choose a reason for hiding this comment

0nandon Feb 3, 2023 •

edited

Loading