[Yan Zaiya] iP #211

skyanzy · 2023-02-01T19:30:49Z

No description provided.

TJW0911 · 2023-02-02T01:49:26Z

src/main/java/Task.java

+        this.isDone = false;
+    }
+
+    //...


Perhaps you could remove this comment

TJW0911 · 2023-02-02T01:53:15Z

src/main/java/Duke.java

+        System.out.println(greet);
+        boolean shouldContinue = true;
+        Scanner in = new Scanner(System.in);
+        //String[] tasks = new String[100];


perhaps remove this comment if you are no longer using it

TJW0911 · 2023-02-02T01:55:04Z

src/main/java/Duke.java

+                }
+                System.out.println(DIVIDER_LINE);
+            }else if (action.startsWith("mark")){
+                int dividerPos = action.indexOf(" ");


Perhaps you could spell out "position" or change it to "Index"

TJW0911 · 2023-02-02T02:01:47Z

src/main/java/Duke.java

+                System.out.println(DIVIDER_LINE + "Nice! I've marked this task as done:\n"
+                        + tasks[toBeMarked].getStatusIcon() + " " + tasks[toBeMarked].description
+                        + "\n" + DIVIDER_LINE);


I think this print statement is a bit lengthy. Perhaps you could use the ToString override method in your classes to shorten it

TJW0911 · 2023-02-02T02:05:54Z

src/main/java/Duke.java

+        String greet = DIVIDER_LINE
+                + "Hello! I'm Duke\n"
+                + "What can i do for you\n"
+                + DIVIDER_LINE;


Good job combining the welcome statement into one string

Thiolk

Overall, the code quality is great although you could consider using switch statements and shortening the print statements to improve the readability of the code.

Thiolk · 2023-02-02T01:41:27Z

src/main/java/Duke.java

+            }else if (action.startsWith("mark")){
+                int dividerPos = action.indexOf(" ");
+                int toBeMarked = Integer.parseInt(action.substring(dividerPos + 1)) - 1;
+                tasks[toBeMarked].markAsDone();
+                System.out.println(DIVIDER_LINE + "Nice! I've marked this task as done:\n"
+                        + tasks[toBeMarked].getStatusIcon() + " " + tasks[toBeMarked].description
+                        + "\n" + DIVIDER_LINE);
+            }else if (action.startsWith("unmark")) {
+                int dividerPos = action.indexOf(" ");
+                int toBeUnmarked = Integer.parseInt(action.substring(dividerPos + 1)) - 1;
+                tasks[toBeUnmarked].markAsUndone();
+                System.out.println(DIVIDER_LINE + "Nice! I've marked this task as undone:\n"
+                        + tasks[toBeUnmarked].getStatusIcon() + " " + tasks[toBeUnmarked].description
+                        + "\n" + DIVIDER_LINE);
+            }else {


Should there be a spacing between the curly brackets and the "else if" and the "else"?

Thiolk · 2023-02-02T02:08:43Z

src/main/java/Duke.java

+                        + tasks[toBeMarked].getStatusIcon() + " " + tasks[toBeMarked].description
+                        + "\n" + DIVIDER_LINE);
+            }else if (action.startsWith("unmark")) {
+                int dividerPos = action.indexOf(" ");


Perhaps you could consider writing your variable name in full?

Thiolk · 2023-02-02T02:20:51Z

src/main/java/Duke.java

+                    System.out.println(Integer.toString(i + 1) + "." + "" +tasks[i].getStatusIcon()
+                            + " " +tasks[i].description);
+                }
+                System.out.println(DIVIDER_LINE);
+            }else if (action.startsWith("mark")){
+                int dividerPos = action.indexOf(" ");
+                int toBeMarked = Integer.parseInt(action.substring(dividerPos + 1)) - 1;
+                tasks[toBeMarked].markAsDone();
+                System.out.println(DIVIDER_LINE + "Nice! I've marked this task as done:\n"
+                        + tasks[toBeMarked].getStatusIcon() + " " + tasks[toBeMarked].description
+                        + "\n" + DIVIDER_LINE);


Good job in ensuring that the character count of each line should not exceed 120 characters.

R-Ramana · 2023-02-11T07:42:55Z

src/main/java/Deadline.java

+
+    @Override
+    public String toString(){
+        return getTypeIcon() + super.getStatusIcon() +super.description + " (by: " + this.by + ")";


Be consistent with the space around +

R-Ramana · 2023-02-11T07:44:18Z

src/main/java/Duke.java

 public class Duke {
+    public static String DIVIDER_LINE = "______________________________\n";
+
    public static void main(String[] args) {


Your main method feels a bit long, can consider modularizing it. According to the textbook, the recommendation is to have 30 LOC.

R-Ramana · 2023-02-11T07:47:12Z

src/main/java/Duke.java

+                taskCount += 1;
+                printNumTask(taskCount);
+            }else if (action.startsWith("event")) {
+                int dividerPosition1 = action.indexOf("/from");


You repeat this line of code quite often. Consider creating a method and passing the respective variable of /from or /by

conflicts resolved # Conflicts: # src/main/java/duke/Duke.java

resolved conflicts # Conflicts: # src/main/java/duke/Duke.java

added find function

Added JavaDoc

skyanzy added 3 commits February 2, 2023 00:38

Duke echoes what the user says

948e367

add and list tasks

ed23c92

added "mark as done or undone"

3443a1a

TJW0911 reviewed Feb 2, 2023

View reviewed changes

Thiolk reviewed Feb 2, 2023

View reviewed changes

added level4 with deadline, todo and event

e45b3f9

R-Ramana reviewed Feb 11, 2023

View reviewed changes

skyanzy and others added 21 commits February 13, 2023 16:53

handled exceptions

266f1af

used exception

348e162

added a package

7a661ff

A-CodingStandard

cade921

improved code quality

fa052ea

no message

080beee

level 5

483db36

Merge branch 'master' into branch-Level-5

33aed0d

conflicts resolved # Conflicts: # src/main/java/duke/Duke.java

dummy commit

4392566

added delete function

22f3a3f

dummy change

226cefa

lvl 7 added save

1d2e544

Merge branch 'branch-Level-7'

8e79147

resolved conflicts # Conflicts: # src/main/java/duke/Duke.java

added find function

4cb3354

Merge pull request #1 from skyanzy/branch-Level-9

0d982de

added find function

some comments

8e72009

Added JavaDoc

0d0c7ea

Merge pull request #2 from skyanzy/A-JavaDoc

20905f4

Added JavaDoc

more OOP

2940847

Update README.md

8e45cf8

Improved coding standard with better OOP. Handled more exceptions

07ecaaa

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Yan Zaiya] iP #211

[Yan Zaiya] iP #211

skyanzy commented Feb 1, 2023

TJW0911 Feb 2, 2023

TJW0911 Feb 2, 2023

TJW0911 Feb 2, 2023

TJW0911 Feb 2, 2023

TJW0911 Feb 2, 2023

Thiolk left a comment

Thiolk Feb 2, 2023

Thiolk Feb 2, 2023

Thiolk Feb 2, 2023

R-Ramana Feb 11, 2023

R-Ramana Feb 11, 2023

R-Ramana Feb 11, 2023

[Yan Zaiya] iP #211

Are you sure you want to change the base?

[Yan Zaiya] iP #211

Conversation

skyanzy commented Feb 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Thiolk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment