[Ong Jun Lin Jeremiah] iP #212

miahjerry · 2023-02-02T03:07:39Z

No description provided.

yixuann02 · 2023-02-02T05:32:57Z

src/main/java/Duke.java

@@ -1,10 +1,73 @@
-public class Duke {
+import java.util.Scanner;
+import java.util.*;


Perhaps you could list the imported classes explicitly

yixuann02 · 2023-02-02T05:40:14Z

src/main/java/Duke.java

+public class
+Duke {


Suggested change

public class

Duke {

public class Duke {

yixuann02 · 2023-02-02T05:45:29Z

src/main/java/Duke.java

        String logo = " ____        _        \n"
                + "|  _ \\ _   _| | _____ \n"
                + "| | | | | | | |/ / _ \\\n"
                + "| |_| | |_| |   <  __/\n"
                + "|____/ \\__,_|_|\\_\\___|\n";
        System.out.println("Hello from\n" + logo);
+
+        String greeting = ("____________________________________________________________\n"
+                + "Hello! I'm Duke\n" + "What can I do for you?\n"
+                + "____________________________________________________________\n"
+        );
+
+        String goodBye = ("____________________________________________________________\n"
+                + "Bye. Hope to see you again soon!\n"
+                + "____________________________________________________________\n");


Perhaps you can change your constant names to be all uppercase using underscore to separate words

yixuann02 · 2023-02-02T05:49:29Z

src/main/java/Duke.java

+                    System.out.println("OK, I've marked this task as not done yet:\n" + "    "
+                            + toDoList.get(itemNumber).getStatusIcon() + toDoList.get(itemNumber).getDescription());


I think you did a good job indenting wrapped lines.

tyuyang · 2023-02-02T06:37:01Z

src/main/java/Duke.java

+        String greeting = ("____________________________________________________________\n"
+                + "Hello! I'm Duke\n" + "What can I do for you?\n"
+                + "____________________________________________________________\n"
+        );
+
+        String goodBye = ("____________________________________________________________\n"
+                + "Bye. Hope to see you again soon!\n"
+                + "____________________________________________________________\n");


You may want to refactor the greeting and goodbye into another function instead of putting it all in main(). For example a void printGreeting() function that just prints the greeting

tyuyang · 2023-02-02T06:40:54Z

src/main/java/Task.java

+public class Task {
+    protected String description;
+    protected boolean isDone;
+    protected int taskNumber;


There are no methods that uses taskNumber?

tyuyang · 2023-02-02T06:42:06Z

src/main/java/Duke.java

        String logo = " ____        _        \n"
                + "|  _ \\ _   _| | _____ \n"
                + "| | | | | | | |/ / _ \\\n"
                + "| |_| | |_| |   <  __/\n"
                + "|____/ \\__,_|_|\\_\\___|\n";
        System.out.println("Hello from\n" + logo);


Can be refactored into print logo function, or you can combine it with the print greeting function

tyuyang · 2023-02-02T06:49:39Z

src/main/java/Duke.java

+        ArrayList<Task> toDoList = new ArrayList<Task>(100);
+
+        while (!userInput.equals("bye")) {
+            if (!containsNumbers(userInput)) {


You probably don't need this if clause. Instead, you can see if the input string contains "list", "mark", or "unmark", and create 3 separate switch cases for them. Even better, you can refactor this entire if else block into a function that parses the user input.

tyuyang · 2023-02-02T06:53:12Z

src/main/java/Duke.java

+                        System.out.print(item.getStatusIcon());
+                        System.out.println(item.getDescription());
+                    }
+                    System.out.println("____________________________________________________________\n");


You can declare a constant for the row of underscores, or you can just create a function printLine to print the row of underscores. Also, you may want to use System.lineSeparator() instead of '\n' as recommended by the module.

tyuyang · 2023-02-02T06:58:37Z

src/main/java/Duke.java

+                        System.out.print((toDoList.indexOf(item) + 1) + ".");
+                        System.out.print(item.getStatusIcon());
+                        System.out.println(item.getDescription());


Can be refactored into a separate function printTask(), since all tasks have the same format to be printed. In addition, depending on the situation, you may want to create a new function for each System.out.print() call, if you print the same thing multiple time.

R-Ramana · 2023-02-11T05:43:17Z

src/main/java/Duke.java

+public class
+Duke {


Please bring Duke { in line 5 to the same line as public class (line 4)

Suggested change

public class

Duke {

public class Duke {

R-Ramana · 2023-02-11T05:47:21Z

src/main/java/Duke.java

+import java.util.ArrayList;
+
+public class
+Duke {
    public static void main(String[] args) {


Your main method is far too long, the recommendation according to the textbook is 30 LOC. Please try to modularize your main method.

This reverts commit bd2b27f.

This reverts commit fcc0a61.

This reverts commit 502d1bc.

Level-9-Find added

Added Java Documentation

miahjerry added 5 commits January 22, 2023 18:55

Increment level 0, added a greeting

2347e0a

Level-1: Greet, Echo, Exit

5697dca

Level-2: Add, List

9d838d8

Level 3. Mark as Done

39997c3

To test for push

9aab82a

yixuann02 reviewed Feb 2, 2023

View reviewed changes

tyuyang reviewed Feb 2, 2023

View reviewed changes

miahjerry added 2 commits February 8, 2023 23:24

Level-4,ToDos-Events-Deadlines

b88f2ef

Level-5,Handle-Errors

f5c800f

R-Ramana reviewed Feb 11, 2023

View reviewed changes

miahjerry and others added 11 commits February 28, 2023 00:30

Modularized code, shortened main

c88df2a

Added comments to explain code

bd2b27f

Revert "Added comments to explain code"

fcc0a61

This reverts commit bd2b27f.

Revert "Revert "Added comments to explain code""

502d1bc

This reverts commit fcc0a61.

Revert "Revert "Revert "Added comments to explain code"""

8ba6193

This reverts commit 502d1bc.

Level-7 Save

2ad344e

Level-9-Find added

6fe26de

Merge pull request #1 from miahjerry/branch-Level-9

8963781

Level-9-Find added

Added Java Documentation

107d97f

Merge pull request #3 from miahjerry/Branch-JavaDoc

d5071ac

Added Java Documentation

Created JAR file

0aa293f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ong Jun Lin Jeremiah] iP #212

[Ong Jun Lin Jeremiah] iP #212

miahjerry commented Feb 2, 2023

yixuann02 Feb 2, 2023

yixuann02 Feb 2, 2023

yixuann02 Feb 2, 2023

yixuann02 Feb 2, 2023

tyuyang Feb 2, 2023

tyuyang Feb 2, 2023

tyuyang Feb 2, 2023

tyuyang Feb 2, 2023

tyuyang Feb 2, 2023

tyuyang Feb 2, 2023

R-Ramana Feb 11, 2023 •

edited

Loading

R-Ramana Feb 11, 2023

		System.out.println("OK, I've marked this task as not done yet:\n" + " "
		+ toDoList.get(itemNumber).getStatusIcon() + toDoList.get(itemNumber).getDescription());

[Ong Jun Lin Jeremiah] iP #212

Are you sure you want to change the base?

[Ong Jun Lin Jeremiah] iP #212

Conversation

miahjerry commented Feb 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

R-Ramana Feb 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

R-Ramana Feb 11, 2023 •

edited

Loading