[Wang Silang] iP #214

JangusRoundstone · 2023-02-02T17:48:30Z

No description provided.

…Complete level 2.

gurmankalkat

Overall, great job structuring the code. Some minor style issues.

gurmankalkat · 2023-02-03T03:36:22Z

src/main/java/Duke.java

+        System.out.println("Sir, your task has been unmarked as requested.");
+    }
+
+    public static void printCurrentList(Task[] list, int numOfItems)


nice job making clear method and variable names!

gurmankalkat · 2023-02-03T03:44:15Z

src/main/java/Duke.java

+    }
+
+    public static void addList()
+    {


Use K&R style brackets (as done in the exitLine method)

gurmankalkat · 2023-02-03T03:45:30Z

src/main/java/Duke.java

+                if(line.startsWith("todo")){
+                    newTask = new ToDos(line);
+                }
+                else if(line.startsWith("deadline")){


change the form of the if/else statements to match the coding standard:

if (condition) {
statements;
} else if (condition) {
statements;
} else {
statements;
}

Yeah, you can refer to this link [https://se-education.org/guides/conventions/java/basic.html] for if-else statement coding standards.

Thanks guys!

gurmankalkat · 2023-02-03T03:51:54Z

src/main/java/Duke.java

@@ -1,3 +1,8 @@
+import jdk.jfr.Event;


where/how is this used?

TopGun2001 · 2023-02-03T05:04:52Z

src/main/java/Duke.java

+                if(line.startsWith("todo")){
+                    newTask = new ToDos(line);
+                }
+                else if(line.startsWith("deadline")){


Yeah, you can refer to this link [https://se-education.org/guides/conventions/java/basic.html] for if-else statement coding standards.

TopGun2001 · 2023-02-03T05:12:54Z

src/main/java/Duke.java

+    {
+        String line;
+        Scanner in = new Scanner(System.in);
+        line = in.nextLine();
+        while(!line.equals("bye")) {
+            System.out.println(line);
+            line = in.nextLine();
+        }
+    }


You'd want to indent the { } properly, like:
public static void echo(){

// your code
}

TopGun2001 · 2023-02-03T05:15:13Z

src/main/java/Task.java

@@ -0,0 +1,31 @@
+public class Task {
+    protected String taskLabel;


I like how you have added another variable called taskLabel.

This is actually clear while storing the data in it instead of explicitly typing [D] / [E] / [T] every time while printing the lists.

Zemdalk

Your indentation is really good. StringBuffer class is really useful, I like the way you use it to deal with strings. Maybe you can replace some "magic numbers" with constants to make your code more readable? Just some personal ideas.

Zemdalk · 2023-02-03T06:02:31Z

src/main/java/Deadlines.java

+    private String endTime;
+    private String taskLabel = "[D]";
+    public Deadlines (String input){
+        super(input.substring(9,input.indexOf('/') - 1)); // Sanitize input by removing "deadline" at the start


Personally, maybe you can replace the number 9 with a constant to avoid "magic numbers"?

Like private static final int DEADLINE_LABEL = 9;?

Agreed. Thanks for the idea!

Zemdalk · 2023-02-03T06:08:48Z

src/main/java/Deadlines.java

+        super.setTaskLabel(taskLabel);
+        endTime = "(" + getEndTime(input) + ")";
+    }
+    // Method of StringBuffer operation taken from


I like the way you use StringBuffer to operate on these strings, it's really useful.

This reverts commit 4eee682.

This reverts commit 21815d8.

wamikamalik

Great Job! A few nits here and there. Do take a look at my comments below.

wamikamalik · 2023-02-18T01:08:43Z

src/main/java/Duke/Duke.java

+    public static void echo() {
+        String line;
+        Scanner in = new Scanner(System.in);
+        line = in.nextLine();
+        while (!line.equals("bye")) {
+            System.out.println(line);
+            line = in.nextLine();
+        }
+    }


You can remove methods that are not being used to reduce redundant code and improve readability.

wamikamalik · 2023-02-18T01:13:53Z

src/main/java/Duke/Duke.java

+            }
+            line = in.nextLine(); // read in next line of text
+        }
+    }


Try to have less that 30 LOC for any method. You can split the contents of this method into multiple methods.

wamikamalik · 2023-02-18T01:14:52Z

src/main/java/Duke/Duke.java

+        System.out.println("Glad I could be of help!");
+    }
+
+    public static void addList() {


Do remember to provide appropriate names to methods. The method below is not just adding a list or adding to a list.

wamikamalik · 2023-02-18T01:18:10Z

src/main/java/Duke/Duke.java

+        }
+        return output;
+    }
+}


Good job refactoring the code!

wamikamalik · 2023-02-18T01:18:51Z

src/main/java/Duke/Exception/EmptyDeadlineException.java

@@ -0,0 +1,4 @@
+package Duke.Exception;


Names representing packages should be in all lower case. Look at Java coding standards for more details.

…evel-7

branch-level-7

branch-A-JavaDoc

* tag 'branch-Level-9': branch-Level-9

JAR released

* master: branch-A-JavaDoc # Conflicts: # src/main/java/Duke/Ui.java

branch-level-9

Gujimugger added 5 commits January 27, 2023 10:42

Level 0: adding greetLine and exitLine

6169785

Level 1: Adding echo function

d047c4e

Level 1,2: Rectify mistake in echo, where "bye" will also be echoed. …

b1f3481

…Complete level 2.

Level 3: Complete level 3, add in printCurrentList function.

e45b36b

Level 4 complete

fbf03b0

gurmankalkat reviewed Feb 3, 2023

View reviewed changes

TopGun2001 reviewed Feb 3, 2023

View reviewed changes

Zemdalk reviewed Feb 3, 2023

View reviewed changes

Gujimugger added 9 commits February 10, 2023 01:23

Level 5 complete

9ac72cf

A-Packages

90cbc52

Level 6 Complete

4eee682

Revert "Level 6 Complete"

21815d8

This reverts commit 4eee682.

Revert "Revert "Level 6 Complete""

21238c7

This reverts commit 21815d8.

Fixing going back to master

d5393f2

Merge branch 'master' into branch-Level-6

55e06c9

Level 7 complete

d98e800

A-Jar

a9eebd0

wamikamalik reviewed Feb 18, 2023

View reviewed changes

Gujimugger and others added 11 commits March 3, 2023 21:37

A-MoreOOP

7688011

Level-9, A-JavaDoc

c240a47

Create user guide for Duke

fde76d5

Merge commit 'fde76d508d756f10c50396b0d6398fed4f2da62d' into branch-L…

da82fc2

…evel-7

Merge pull request #1 from JangusRoundstone/branch-Level-7

d9e6240

branch-level-7

branch-Level-9

e202337

branch-A-JavaDoc

806f874

Merge pull request #2 from JangusRoundstone/branch-A-JavaDoc

4b7e1b8

branch-A-JavaDoc

Merge tag 'branch-Level-9'

d703de1

* tag 'branch-Level-9': branch-Level-9

Published UG

399c136

JAR released

Merge branch 'master' into branch-Level-9

d914533

* master: branch-A-JavaDoc # Conflicts: # src/main/java/Duke/Ui.java

Merge pull request #3 from JangusRoundstone/branch-Level-9

b8552f4

branch-level-9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Wang Silang] iP #214

[Wang Silang] iP #214

JangusRoundstone commented Feb 2, 2023

gurmankalkat left a comment •

edited

Loading

gurmankalkat Feb 3, 2023

gurmankalkat Feb 3, 2023

gurmankalkat Feb 3, 2023

TopGun2001 Feb 3, 2023

JangusRoundstone Feb 8, 2023

gurmankalkat Feb 3, 2023

TopGun2001 Feb 3, 2023

TopGun2001 Feb 3, 2023

TopGun2001 Feb 3, 2023

Zemdalk left a comment

Zemdalk Feb 3, 2023

JangusRoundstone Feb 8, 2023

Zemdalk Feb 3, 2023

wamikamalik left a comment

wamikamalik Feb 18, 2023

wamikamalik Feb 18, 2023

wamikamalik Feb 18, 2023

wamikamalik Feb 18, 2023

wamikamalik Feb 18, 2023

		@@ -0,0 +1,31 @@
		public class Task {
		protected String taskLabel;

[Wang Silang] iP #214

Are you sure you want to change the base?

[Wang Silang] iP #214

Conversation

JangusRoundstone commented Feb 2, 2023

gurmankalkat left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zemdalk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wamikamalik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gurmankalkat left a comment •

edited

Loading