q13, q14, q15, q16 を解答 #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takegue
reviewed
Nov 25, 2016
| open("col2.txt", "r") as col2_f,\ | ||
| open("col12.txt", "w") as col12_f: | ||
| for col1, col2 in zip(col1_f, col2_f): | ||
| print("{}\t{}".format(col1.rstrip("\r\n"), |
takegue
reviewed
Nov 25, 2016
| open("col2.txt", "r") as col2_f,\ | ||
| open("col12.txt", "w") as col12_f: | ||
| for col1, col2 in zip(col1_f, col2_f): | ||
| print("{}\t{}".format(col1.rstrip("\r\n"), |
ghost
changed the title
kanjirz50
reviewed
Nov 25, 2016
| path = args[2] | ||
|
|
||
| with open(path, "r") as fin: | ||
| print(*deque(fin, n), sep="", end="") |
kanjirz50
reviewed
Nov 25, 2016
| import sys | ||
| from collections import deque | ||
|
|
||
| args = sys.argv |
There was a problem hiding this comment.
これくらい単純なプログラムはsys.argvでも良いと思います。
高機能なargparseが使えるようになると、言語処理では結構できることが広がるかと
There was a problem hiding this comment.
外部ライブラリを何かライブラリを使うなら clickってやつがオススメです.
http://click.pocoo.org/5/
takegue
reviewed
Nov 26, 2016
| open("col2.txt", "r") as col2_f,\ | ||
| open("col12.txt", "w") as col12_f: | ||
| for col1, col2 in zip(col1_f, col2_f): | ||
| print("{}\t{}".format(col1.rstrip(), col2.rstrip()), file=col12_f) |
There was a problem hiding this comment.
print(col1.rstrip(), col2.rstrip(), file=col12_f, sep='\t')
の方がコードが読みやすくなりますね
takegue
reviewed
Nov 26, 2016
| path = args[2] | ||
|
|
||
| with open(path, "r") as fin: | ||
| for i in range(n): |
There was a problem hiding this comment.
readlineよりもenumerateとfileのイテレータを活用しよう
for idx, line in enumerate(fin):
if idx > n : break
print(line, end='')
|
q16 も解答しました |
takegue
reviewed
Dec 2, 2016
| n = int(args[1]) | ||
| path = args[2] | ||
| with open(path, "r") as f: | ||
| total_line_num = count_file_lines(f) |
There was a problem hiding this comment.
行数数えるときはジェネレータ式を使ってシアみたいな書き方すると見やすいです。
n_lines = sum(1 for _ in open('file'))
takegue
reviewed
Dec 2, 2016
| with open(path, "r") as f: | ||
| total_line_num = count_file_lines(f) | ||
| l = devide_num(total_line_num, n) | ||
| for i, line_num in enumerate(l): |
There was a problem hiding this comment.
N分割するための処理ですが, 以下のような書き方もできますね.
from itertools import zip_longest
def grouper(iterable, n)
it = [iter(iterable)] * n
return zip_longest(*it, fillvalue='')
# M行(=math.ceil(n_lines / N) )にまとめる処理はこっちの方が書きやすいですね
for idx, lines in grouper(file, n_lines // N):
with open('{}.{}'.format(path, idx), 'w') as fout:
print( ''.join(lines).strip(), file=fout) from itertools import groupby
# N分割する処理はこっちの方が書きやすいですね
for idx, lines in groupby(enumerate(file), key=lambda idx, line: idx//N):
with open('{}.{}'.format(path, idx), 'w') as fout:
print(''.join(lines).strip(), file=fout) #連続する改行をstripで消しています
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.