feat(Table): add pagination feature #2654
Draft
+35
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benjamincanac if you have time I would appreciate it when you can provide some html and base styling for this new feature. |
src/runtime/components/Table.vue
Outdated
Comment on lines
282
to
286
| <slot name="pagination"> | ||
| <div :class="ui.pagination({ class: [props.ui?.pagination] })"> | ||
| <UPagination v-if="tableApi.getPageCount() > 1" v-model:page="page" :items-per-page="1" :total="tableApi.getPageCount()" /> | ||
| </div> | ||
| </slot> |
There was a problem hiding this comment.
Not sure about this, I would not include the UPagination component inside the Table to let users handle it the way they want and put it wherever they want I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#2441
❓ Type of change
📚 Description
I've added pagination to the Table component by integrating the existing pagination component we have. This should help users navigate through large datasets more easily by breaking the data into pages.
I updated the playground table page so it shows the pagination.
Since I am bad at html and css I would like to get some help here so it fits well into the Table component.
I will update the documentation aswell once the html and css is done.
📝 Checklist