Migrate from jest to vitest (wip) #92
Conversation
ayushmanchhabra
changed the title
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
|
I've noticed that the failing tests have a pattern: Object {
"customLogger": [Function spy],
"linux": Object {
"filePath": "/home/DUMMY/file.ext",
- "outputPath": "/home/DUMMY/folder/file.desktop",
+ "outputPath": "/home/ayushmanchhabra/Desktop/file.desktop",
},
"onlyCurrentOS": true,
"verbose": true,
}How can we mock the dir path? |
|
@TheJaredWilcurt ping |
tests/setup.js
Outdated
| if (os.platform() !== 'win32') { | ||
| import testHelpers from './testHelpers.js'; | ||
|
|
||
| if (process.platform !== 'win32') { |
There was a problem hiding this comment.
I don't remember why, but I do remember setting up all the process.platform/os.platform stuff was done intentionally and was annoying to get working. Not sure why, but I think it was more of a cross-platform node thing, than a jest thing. so would probably still be needed, but not sure.
There was a problem hiding this comment.
Setup file useful for running commands which are common to the whole test case - such as afterAll, beforeEach, etc
| @@ -3,19 +3,17 @@ | |||
| * @author TheJaredWilcurt | |||
| */ | |||
|
|
|||
| jest.mock('os'); | |||
There was a problem hiding this comment.
I think it was related to this, where we mock out the OS module to fake which OS we are on for certain tests.
There was a problem hiding this comment.
Some modules are mocked successfully while others aren't such as node:os - will look into it when I get time
There was a problem hiding this comment.
I think I mocked out one way of checking the OS/platform, and exclusively used that way of checking for it in the library. That way I could pretend to be a different OS in the tests. But also I still needed a way to check the real OS that was running the tests, because it would have different behavior and the tests still needed to pass on all real OS's. So I used a different way to check the real OS that wasn't mocked. I think that's what was going on with process.platform vs require('os').platform().
Fixes: #82