Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Management #5

Open
wants to merge 4 commits into
base: testing
Choose a base branch
from
Open

Group Management #5

wants to merge 4 commits into from

Conversation

V-inz
Copy link
Contributor

@V-inz V-inz commented Jan 5, 2017

Currently ctx.ID.Groups[] is missing at start;

What if you get a GroupTextMessage but did never/not jet get the GroupManageSetMembersMessage (because you setup your client newly)? Think you have to create a new group with known info.

Think you get this problem in real Threema too, if you recover from a ID-backup.

Copy link
Contributor

@willnix willnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put this on hold for now because we are working on proper group maanagement in the library.
The demo app should use functions offered by o3 as soon as they exist.
Thank you very much for the input!

@willnix
Copy link
Contributor

willnix commented Jan 5, 2017

I think it is not a good idea to add groups on the fly if we receive messages for them.
This breaks the group security model because people other than the group administrator can ad them self to groups. I will investigate if there is a way to ask group creators for resync. AFAIK the creator can only initiate a resync manually.
resync

@V-inz
Copy link
Contributor Author

V-inz commented Jan 5, 2017

know that manual sync, triggered by the GroupCreator.
can't believe, everyone can ask anyone silently to sync his groups ... (bothers me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants