Fix response handler #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxtruxa
suggested changes
Nov 3, 2016
| @@ -24,7 +24,7 @@ | |||
| "dependencies": { | |||
| "bluebird": "^3.0.5", | |||
| "express": "^4.13.3", | |||
| "oauth2-server": "next", | |||
| "oauth2-server": "kinvey/node-oauth2-server#kinvey", | |||
There was a problem hiding this comment.
This should probably stay at "next". 😉
|
Tests fixed with #33. |
mjsalinger
force-pushed
the
fix-response-handler
branch
from
dd93f0b to
cf51252
Compare
mjsalinger
force-pushed
the
fix-response-handler
branch
from
cf51252 to
660f586
Compare
|
Rebased to remove some duplicate commits and incorporate latest changes to |
maxtruxa
approved these changes
Nov 11, 2016
| res.set(response.headers); | ||
| res.redirect(location); | ||
| } | ||
| else { |
There was a problem hiding this comment.
Style-wise.. Are we going by the 1TBS
} else {
or Stroustrup?
}
else {
|
@mjsalinger
|
|
302 is the default used in the oauth2 spec.. Others are allowed, and I think that's a good idea to add support for, but I think that should be a separate PR for a future release. |
|
Added issue #37 to track. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.