Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump should from 7.1.1 to 13.2.3 #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link

Bumps should from 7.1.1 to 13.2.3.

Release notes

Sourced from should's releases.

13.1.3

Fix #157

13.1.2

Revert in ts definition default export back to that was in 13.0.0

13.1.1

.rejecteWith in ts definition was missing return type

13.1.0

New

  1. Now all zero argument assertions throw TypeError in case any argument passed to them.
  2. Aliased .fulfill/.fulfilledWith to .resolve/.resolvedWith

Fixes

  1. TS definition fixed to allow such imports:
import should from 'should';

13.0.1

Add back missing umd build in root of package

13.0.0

Breaking changes

  1. Removed .enumerable, .enumerables (deprecated since 11.2.0)
  2. Fix for shouldjs/should.js#150

New

Added Typescript bindings (still considering this as beta as i am TS newbie)

Better Map Set equality

Map/Set/WeakMap/WeakSet equality checks

User @BridgeAR pointed to a number of bugs and inconcistency in Map/Set/WeakMap/WeakSet checks. To fix all this things, i switched map and set equality checks to do key checks defined in standard instead of value checks. Typical example that was working before this release:

const m1 = new Map([[{ a: 1 }, 11]]);
const m2 = new Map([[{ a: 1 }, 11]]);
m1.should.be.eql(m2)

And not this example is breaking. At first view it is a bit unclear why it should not be so. Consider another example:

const m1 = new Map([[{}, 11], [{}, 12]]);
const m2 = new Map([[{}, 11], [{}, 12]]);
m1.should.be.eql(m2)

This example is not that clear if it should assert or not, right? (it should).

... (truncated)
Changelog

Sourced from should's changelog.

13.2.3 / 2018-07-30

  • .only.keys throws when no Object.prototype.should

13.2.2 / 2018-07-26

  • Updates for TS definition

13.2.1 / 2018-01-12

  • Fix .size to work with should/as-function

13.2.0 / 2017-12-27

  • Update type adaptors to allow to use Set as iterable everywhere

13.1.3 / 2017-10-28

  • Fix weird bug in .containDeep when given object is string (see #157)

13.1.2 / 2017-10-10

  • Revert default export in TS definition (added in 13.1.0)

13.1.1 / 2017-10-07

  • Added missing return type for .rejectedWith in typescript definition

13.1.0 / 2017-09-20

  • Added .resolved as alias to .fulfilled
  • Added .resolvedWith as alias to .fulfilledWith
  • All zero argument assertion will throw TypeError if any arg passed
  • Fix default export for TS definition

13.0.1 / 2017-09-06

  • Add missing UMD bundle for browser

13.0.0 / 2017-09-05

  • Removed .enumerable and .enumerables
  • Fixed .matching on Dates
  • Added TypeScript definitions

12.0.0 / 2017-08-28

  • Update should-equal to 2.x
  • Update entry points to do the same thing (global should entry)
... (truncated)
Commits
  • 38910f7 Release 13.2.3
  • 40db606 Do not use getter internally
  • 031b8e6 Release 13.2.2
  • 6db456c Merge branch 'master' of github.com:shouldjs/should.js
  • 1ab1661 Add note about TS
  • 889e22e Merge pull request #171 from jsoref/spelling
  • 79ec809 Spelling fixes
  • 0abf2d5 Merge pull request #167 from lumaxis/bugfix/typescript-error
  • d1e9efe Fix TypeScript compiler issue with fulfilled assertion
  • 9dcde0f Merge pull request #164 from chris-grabcad/UpdateDefinitionsOfTrueAndFalseInT...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants