Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #1041

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Cleanup #1041

merged 1 commit into from
Nov 20, 2024

Conversation

smorimoto
Copy link
Member

@smorimoto smorimoto commented Nov 18, 2024

  • use bisect_ppx via instrumentation
  • format dune files with dune build @fmt --auto-promote
  • remove unused dune fields (e.g. (preprocess (future_syntax)))
  • remove unnecessary conditional branches in ci
  • remove unused warning definitions

@smorimoto smorimoto force-pushed the cleanup branch 2 times, most recently from e165bb4 to c75b277 Compare November 18, 2024 20:54
@smorimoto smorimoto marked this pull request as ready for review November 18, 2024 20:55
@smorimoto smorimoto force-pushed the cleanup branch 3 times, most recently from 9f879c2 to 794adf7 Compare November 18, 2024 22:24
@smorimoto
Copy link
Member Author

For ease of review, I recommend enabling the "hide whitespaces" mode.

image

Signed-off-by: Sora Morimoto <[email protected]>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 17 out of 35 changed files in this pull request and generated no suggestions.

Files not reviewed (18)
  • Makefile: Language not supported
  • dune-project: Language not supported
  • lwt.opam: Language not supported
  • lwt_ppx.opam: Language not supported
  • lwt_react.opam: Language not supported
  • lwt_retry.opam: Language not supported
  • src/core/dune: Language not supported
  • src/core/lwt.ml: Language not supported
  • src/core/lwt_condition.ml: Language not supported
  • src/core/lwt_mutex.ml: Language not supported
  • src/core/lwt_mvar.ml: Language not supported
  • src/core/lwt_pool.ml: Language not supported
  • src/ppx/dune: Language not supported
  • src/react/dune: Language not supported
  • src/retry/dune: Language not supported
  • src/unix/dune: Language not supported
  • src/unix/lwt_bytes.ml: Language not supported
  • src/unix/lwt_engine.ml: Language not supported
@smorimoto smorimoto merged commit 7eab825 into master Nov 20, 2024
48 of 49 checks passed
@smorimoto smorimoto deleted the cleanup branch November 20, 2024 16:33
@smorimoto
Copy link
Member Author

@MisterDA Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants