Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Update libsecp256k1 to v0.5.0 #169

Merged
merged 7 commits into from
Jun 29, 2024

Conversation

MementoRC
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.68%. Comparing base (ddfa9bb) to head (16c300a).
Report is 2 commits behind head on master.

Current head 16c300a differs from pull request most recent head 6e0bb1a

Please upload reports for the commit 6e0bb1a to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   33.68%   33.68%           
=======================================
  Files          12       12           
  Lines         567      567           
  Branches       67       67           
=======================================
  Hits          191      191           
  Misses        376      376           

@MementoRC
Copy link
Collaborator Author

@ofek I am updating the libsecp256k1 to v0.5.0 and also removing setting the COINCURVE_UPSTREAM_REF in several location. Since we are using pyproject, we can define only there. There is still a reference (the 0.4.1) in the CMakeLists.txt, in the odd case someone wouldn't use pyproject

@MementoRC MementoRC merged commit 36acb70 into ofek:master Jun 29, 2024
19 checks passed
@MementoRC MementoRC deleted the feat/secp256k1_v0.5.0 branch June 29, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants