hpx-parcelport analysis/code review skeleton #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ct-clmsn
changed the title
Signed-off-by: Chris Taylor <ctdotclmsnatgmaildotcom>
Signed-off-by: Chris Taylor <ct(dot)clmsn(at)gmail(dot)com>
|
@shefty thought i had my DCO conflict issues resolved. will fix later. |
…_controller Signed-off-by: Chris Taylor <ct(dot)clmsn(at)gmail(dot)com>
|
@ct-clmsn - You may want to look at using stgit (stack git) to manage patch series. It just wraps around raw git commands, but I find it easier to manipulate patches using it. It stores patches in a stack, that you can push and pop onto your tree. This makes it easy to remove patches, adjust one lower down in a series, then push the patches back onto the git tree. So you can fix a patch directly, rather than creating another patch for the same fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR should provide interested parties with a sense of what the code analysis will look like going forward. please comment on the PR if there is something missing or if something seems inadequate.