[v2.0.x] prov/shm,lpp: cherry-picked commits #10656
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aingerson
commented
Dec 21, 2024
aingerson
commented
- Fix lpp configure bug - check for atomics and don't build if not found
- Fix shm name compare bug
Could result in a peer getting incorrectly unmmaped Cherry-picked from commit 442fa89 Signed-off-by: Alexia Ingerson <[email protected]>
lpp includes stdatomic.h but does not include a check for it in the configure so can cause a build to fail on a system without it Cherry-picked from commit ba824d0 Signed-off-by: Alexia Ingerson <[email protected]>
shijin-aws
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.