-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add golangci-lint for static check. #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for contributing with this PR~
I should appologize to you that I didn't describe clear enough on #69.
It will be nice if you can adjust this PR with the following requirements:
- Remove .golangci.yml (I will be more prefer to have the default settings, since I don't want to have too many customized options). You can give me reasons if you think keeping it will be better.
- Combine
Golangci Lint
&Build and Test
action together into one job, this should save some resource (ormake build
will run twice sincetest
andcilint
are in different jobs)
Hi, thanks for the review. :) |
If could, apply it to existing code, but we may push this target gently (or later). I not so sure if current code can totally pass the check. I also decide to replace |
36c1280
to
0e3dcb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
You will receive invitations to join OJ Lab in your email, also there is a QQ group invitation for the one we can find in our directories o.O |
Close #48
Add golangci-lint for static check.